Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 3174020: Add stdout param to SubprocessCallAndFilter(). (Closed)

Created:
10 years, 4 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Add stdout param to SubprocessCallAndFilter(). It will eventually replace 'print_messages' and be used to annotate printed lines when using --jobs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57092

Patch Set 1 #

Patch Set 2 : fix unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -18 lines) Patch
M gclient.py View 1 chunk +2 lines, -0 lines 0 comments Download
M gclient_scm.py View 1 2 chunks +4 lines, -2 lines 0 comments Download
M gclient_utils.py View 1 6 chunks +10 lines, -9 lines 0 comments Download
M scm.py View 6 chunks +11 lines, -6 lines 0 comments Download
M tests/gclient_utils_test.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
10 years, 4 months ago (2010-08-19 20:49:07 UTC) #1
bradn
10 years, 4 months ago (2010-08-19 22:03:28 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698