Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: gclient_scm.py

Issue 3174020: Add stdout param to SubprocessCallAndFilter(). (Closed)
Patch Set: fix unit test Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gclient.py ('k') | gclient_utils.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient_scm.py
diff --git a/gclient_scm.py b/gclient_scm.py
index be176fb4554c42f205166f35e6b908ba26877afa..50d9be7cf410aebc76d69d565a550054b84fa353 100644
--- a/gclient_scm.py
+++ b/gclient_scm.py
@@ -154,7 +154,8 @@ class GitWrapper(SCMWrapper):
merge_base = self._Run(['merge-base', 'HEAD', 'origin'])
command = ['diff', merge_base]
filterer = DiffFilterer(self.relpath)
- scm.GIT.RunAndFilterOutput(command, path, False, False, filterer.Filter)
+ scm.GIT.RunAndFilterOutput(command, path, False, False, filterer.Filter,
+ stdout=options.stdout)
def update(self, options, args, file_list):
"""Runs git to update or transparently checkout the working copy.
@@ -706,7 +707,8 @@ class SVNWrapper(SCMWrapper):
command.extend(args)
filterer = DiffFilterer(self.relpath)
- scm.SVN.RunAndFilterOutput(command, path, False, False, filterer.Filter)
+ scm.SVN.RunAndFilterOutput(command, path, False, False, filterer.Filter,
+ stdout=options.stdout)
def update(self, options, args, file_list):
"""Runs svn to update or transparently checkout the working copy.
« no previous file with comments | « gclient.py ('k') | gclient_utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698