Issue 3173035: Make sure that our version of certain utility function implementations gets used in the firmware.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3173035: Make sure that our version of certain utility function implementations gets used in the firmware. (Closed)

Created:
10 years, 4 months ago by gauravsh

Modified:
9 years, 6 months ago

Reviewers:
Randall Spangler

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
http://src.chromium.org/git/vboot_reference.git

Visibility:
Public.

Description

Make sure that our version of certain utility function implementations gets used in the firmware. Reference code drop-in to firmware should make our implementations of Memset() and SafeMemcmp() get used now. BUG=chrome-os-partner:820 TEST=make && make runtests Change-Id: If0c06dfad85b67398a118985cdb751d20b2b65a4

Patch Set 1 #

Patch Set 2 : fix typo #

Total comments: 1

Patch Set 3 : . #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -28 lines)			Patch
M	firmware/Makefile	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	firmware/include/utility.h	View	1 2	2 chunks	+4 lines, -1 line	0 comments	Download
M	firmware/lib/stateful_util.c	View		1 chunk	+1 line, -2 lines	0 comments	Download
A	firmware/lib/utility.c	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download
M	firmware/stub/utility_stub.c	View		1 chunk	+0 lines, -24 lines	0 comments	Download
M	firmware/version.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Randall Spangler

10 years, 4 months ago (2010-08-20 21:25:43 UTC) #2

LGTM

http://codereview.chromium.org/3173035/diff/2001/3002
File firmware/include/utility.h (right):

http://codereview.chromium.org/3173035/diff/2001/3002#newcode56
firmware/include/utility.h:56: 
Extra whitespace?

Expand Messages | Collapse Messages