Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: firmware/stub/utility_stub.c

Issue 3173035: Make sure that our version of certain utility function implementations gets used in the firmware. (Closed) Base URL: http://src.chromium.org/git/vboot_reference.git
Patch Set: . Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « firmware/lib/utility.c ('k') | firmware/version.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: firmware/stub/utility_stub.c
diff --git a/firmware/stub/utility_stub.c b/firmware/stub/utility_stub.c
index ed58e0b24c260097741d5ce34ff767a3fd35c7e6..61417856985b5d5c85a2fa1a5ed5251e2dbd2d9b 100644
--- a/firmware/stub/utility_stub.c
+++ b/firmware/stub/utility_stub.c
@@ -51,27 +51,3 @@ int Memcmp(const void* src1, const void* src2, size_t n) {
void* Memcpy(void* dest, const void* src, uint64_t n) {
return memcpy(dest, src, (size_t)n);
}
-
-void* Memset(void* d, const uint8_t c, uint64_t n) {
- uint8_t* dest = d; /* the only way to keep both cl and gcc happy */
- while (n--) {
- *dest++ = c;
- }
- return dest;
-}
-
-
-int SafeMemcmp(const void* s1, const void* s2, size_t n) {
- int result = 0;
- if (0 == n)
- return 1;
-
- const unsigned char* us1 = s1;
- const unsigned char* us2 = s2;
- /* Code snippet without data-dependent branch due to
- * Nate Lawson (nate@root.org) of Root Labs. */
- while (n--)
- result |= *us1++ ^ *us2++;
-
- return result != 0;
-}
« no previous file with comments | « firmware/lib/utility.c ('k') | firmware/version.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698