chrome/installer/util/google_chrome_distribution.cc - Issue 3172009: Cleanup Registry API: part 3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/google_chrome_distribution.cc

Issue 3172009: Cleanup Registry API: part 3. (Closed) Base URL: git://git.chromium.org/chromium.git

Patch Set: chrome fixes Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/util/google_chrome_distribution.cc

diff --git a/chrome/installer/util/google_chrome_distribution.cc b/chrome/installer/util/google_chrome_distribution.cc

index 8a2069dfed8176b2225b419aea392a660a9aec76..adb5b1ace605f6040adca9be5f0125c0c2725cfb 100644

--- a/chrome/installer/util/google_chrome_distribution.cc

+++ b/chrome/installer/util/google_chrome_distribution.cc

@@ -412,7 +412,7 @@ std::wstring GoogleChromeDistribution::GetDistributionData(RegKey* key) {

sub_key.append(L"\\");

sub_key.append(product_guid());

- RegKey client_state_key(key->Handle(), sub_key.c_str());

+ RegKey client_state_key(key->Handle(), sub_key.c_str(), KEY_READ);

std::wstring result;

std::wstring brand_value;

if (client_state_key.ReadValue(google_update::kRegRLZBrandField,

« no previous file with comments | « chrome/installer/setup/uninstall.cc ('k') | chrome/installer/util/install_util.cc » ('j') | no next file with comments »