chrome/installer/setup/uninstall.cc - Issue 3172009: Cleanup Registry API: part 3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/uninstall.cc

Issue 3172009: Cleanup Registry API: part 3. (Closed) Base URL: git://git.chromium.org/chromium.git

Patch Set: chrome fixes Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/setup/uninstall.cc

diff --git a/chrome/installer/setup/uninstall.cc b/chrome/installer/setup/uninstall.cc

index 2d19ca43f38807e23c8d424726d8e7d4a69ad859..f8c048256156c05c4b77eb282ea1dedacb664318 100644

--- a/chrome/installer/setup/uninstall.cc

+++ b/chrome/installer/setup/uninstall.cc

@@ -72,7 +72,7 @@ bool CurrentUserHasDefaultBrowser(bool system_uninstall) {

std::wstring reg_key(ShellUtil::kRegStartMenuInternet);

BrowserDistribution* dist = BrowserDistribution::GetDistribution();

reg_key.append(L"\\" + dist->GetApplicationName() + ShellUtil::kRegShellOpen);

- RegKey key(HKEY_LOCAL_MACHINE, reg_key.c_str());

+ RegKey key(HKEY_LOCAL_MACHINE, reg_key.c_str(), KEY_READ);

std::wstring reg_exe;

if (key.ReadValue(L"", &reg_exe) && reg_exe.length() > 2) {

std::wstring chrome_exe = installer::GetChromeInstallPath(system_uninstall);