Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3170020: Completely revert all my IPC work to see if this was what regressed the page cycler. (Closed)

Created:
10 years, 4 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
Reviewers:
huanr, Matt Perry
CC:
chromium-reviews, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, brettw-cc_chromium.org, jam, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, native-client-reviews_googlegroups.com, stuartmorgan+watch_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Completely revert all my IPC work to see if this was what regressed the page cycler. BUG=51411, 52103 TEST=page cycler Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56272

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1556 lines, -2890 lines) Patch
M base/tuple.h View 10 chunks +108 lines, -156 lines 0 comments Download
M chrome/browser/extensions/extension_messages_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/importer/firefox_importer_unittest_utils_mac.cc View 1 chunk +1 line, -6 lines 0 comments Download
D chrome/browser/importer/importer_messages.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_gtk.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/sync_resource_handler.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/visitedlink_event_listener.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/chrome_common.gypi View 7 chunks +4 lines, -13 lines 0 comments Download
M chrome/common/common_param_traits.h View 5 chunks +40 lines, -5 lines 0 comments Download
M chrome/common/common_param_traits.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/common/devtools_messages.cc View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/common/gpu_messages.cc View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/common/nacl_messages.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/common/nacl_messages_internal.h View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/plugin_messages.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/common/render_messages.h View 1 16 chunks +792 lines, -90 lines 0 comments Download
D chrome/common/render_messages.cc View 1 chunk +0 lines, -923 lines 0 comments Download
M chrome/common/render_messages_internal.h View 3 chunks +12 lines, -10 lines 0 comments Download
M chrome/common/render_messages_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/resource_dispatcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/resource_dispatcher_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/service_messages.cc View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/common/utility_messages.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/common/webkit_param_traits.h View 4 chunks +131 lines, -23 lines 0 comments Download
D chrome/common/webkit_param_traits.cc View 1 chunk +0 lines, -170 lines 0 comments Download
D chrome/common/worker_messages.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/plugin/plugin_thread.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/blocked_plugin.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/indexed_db_dispatcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/pepper_devices.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/render_thread.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/render_view.cc View 1 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/renderer/render_widget.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/renderer/renderer_webcookiejar_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_dom_feature_extractor_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/webplugin_delegate_pepper.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/webplugin_delegate_pepper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/automation/automation_messages.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M ipc/ipc_fuzzing_tests.cc View 1 chunk +0 lines, -1 line 0 comments Download
D ipc/ipc_message_impl_macros.h View 1 chunk +0 lines, -674 lines 0 comments Download
M ipc/ipc_message_macros.h View 40 chunks +285 lines, -348 lines 0 comments Download
M ipc/ipc_message_utils.h View 13 chunks +181 lines, -110 lines 0 comments Download
M ipc/ipc_message_utils.cc View 3 chunks +0 lines, -127 lines 0 comments Download
D ipc/ipc_message_utils_impl.h View 1 chunk +0 lines, -60 lines 0 comments Download
M ipc/ipc_send_fds_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ipc/sync_socket_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M printing/pdf_ps_metafile_cairo.h View 1 chunk +0 lines, -2 lines 0 comments Download
M printing/pdf_ps_metafile_cairo.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
huanr: rubber stamp mpcomplete: FYI
10 years, 4 months ago (2010-08-16 18:38:34 UTC) #1
huanr
10 years, 4 months ago (2010-08-16 18:46:13 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698