chrome/browser/extensions/extension_messages_unittest.cc - Issue 3170020: Completely revert all my IPC work to see if this was what regressed the page cycler.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/extension_messages_unittest.cc

Issue 3170020: Completely revert all my IPC work to see if this was what regressed the page cycler. (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: Rebase Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « base/tuple.h ('k') | chrome/browser/importer/firefox_importer_unittest_utils_mac.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/values.h"

6 #include "chrome/browser/extensions/extension_message_service.h"	5 #include "chrome/browser/extensions/extension_message_service.h"

7 #include "chrome/common/render_messages.h"	6 #include "chrome/common/render_messages.h"

8 #include "chrome/renderer/extensions/event_bindings.h"	7 #include "chrome/renderer/extensions/event_bindings.h"

9 #include "chrome/renderer/extensions/renderer_extension_bindings.h"	8 #include "chrome/renderer/extensions/renderer_extension_bindings.h"

10 #include "chrome/test/render_view_test.h"	9 #include "chrome/test/render_view_test.h"

11 #include "testing/gtest/include/gtest/gtest.h"	10 #include "testing/gtest/include/gtest/gtest.h"

12	11

13 static void DispatchOnConnect(int source_port_id, const std::string& name,	12 static void DispatchOnConnect(int source_port_id, const std::string& name,

14 const std::string& tab_json) {	13 const std::string& tab_json) {

15 ListValue args;	14 ListValue args;

(...skipping 126 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
142	141

143 // Verify that we got it.	142 // Verify that we got it.

144 alert_msg =	143 alert_msg =

145 render_thread_.sink().GetUniqueMessageMatching(	144 render_thread_.sink().GetUniqueMessageMatching(

146 ViewHostMsg_RunJavaScriptMessage::ID);	145 ViewHostMsg_RunJavaScriptMessage::ID);

147 ASSERT_TRUE(alert_msg);	146 ASSERT_TRUE(alert_msg);

148 iter = IPC::SyncMessage::GetDataIterator(alert_msg);	147 iter = IPC::SyncMessage::GetDataIterator(alert_msg);

149 ASSERT_TRUE(IPC::ReadParam(alert_msg, &iter, &alert_param));	148 ASSERT_TRUE(IPC::ReadParam(alert_msg, &iter, &alert_param));

150 EXPECT_EQ(L"disconnected: 24", alert_param.a);	149 EXPECT_EQ(L"disconnected: 24", alert_param.a);

151 }	150 }

OLD	NEW