Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3170010: [update_engine] Update to use not-hideously-old logging API from chrome (Closed)

Created:
10 years, 4 months ago by Chris Masone
Modified:
9 years, 7 months ago
Reviewers:
petkov
CC:
chromium-os-reviews_chromium.org, petkov, adlr
Base URL:
http://src.chromium.org/git/update_engine.git
Visibility:
Public.

Description

[update_engine] Update to use not-hideously-old logging API from chrome BUG=None TEST=compile Change-Id: Ieed8952b6806a72b59e16c1579f7293b6a98157a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -35 lines) Patch
M action.h View 1 chunk +1 line, -1 line 0 comments Download
M action_pipe.h View 1 chunk +1 line, -1 line 0 comments Download
M cycle_breaker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M delta_diff_generator.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M delta_diff_generator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extent_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M file_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M filesystem_iterator.cc View 1 chunk +1 line, -1 line 0 comments Download
M generate_delta_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M gzip.cc View 1 chunk +1 line, -1 line 0 comments Download
M http_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M install_plan.h View 1 chunk +1 line, -1 line 0 comments Download
M libcurl_http_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M libcurl_http_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M main.cc View 1 chunk +1 line, -1 line 0 comments Download
M mock_http_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mock_http_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M omaha_hash_calculator.cc View 1 chunk +1 line, -1 line 0 comments Download
M omaha_request_action.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M prefs.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M subprocess.h View 1 chunk +1 line, -1 line 0 comments Download
M subprocess.cc View 1 chunk +1 line, -1 line 0 comments Download
M tarjan.cc View 1 chunk +1 line, -1 line 0 comments Download
M tarjan_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test_http_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M utils.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Chris Masone
10 years, 4 months ago (2010-08-12 02:24:45 UTC) #1
Chris Masone
On 2010/08/12 02:24:45, Chris Masone wrote: > redirect to petkov; adlr is OOO this AM
10 years, 4 months ago (2010-08-12 17:30:57 UTC) #2
petkov
10 years, 4 months ago (2010-08-12 17:38:02 UTC) #3 
LGTM

(although it might have been nice to also run the unit tests and test on device)

Powered by Google App Engine
This is Rietveld 408576698