omaha_request_action.cc - Issue 3170010: [update_engine] Update to use not-hideously-old logging API from chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: omaha_request_action.cc

Issue 3170010: [update_engine] Update to use not-hideously-old logging API from chrome (Closed) Base URL: http://src.chromium.org/git/update_engine.git

Patch Set: Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: omaha_request_action.cc

diff --git a/omaha_request_action.cc b/omaha_request_action.cc

index cd318051b2cb1a11d87831d20dbd5570ae0b18e0..1c79fb06949e1ab7c623aaae5ea6d4f2fc119de2 100644

--- a/omaha_request_action.cc

+++ b/omaha_request_action.cc

@@ -10,9 +10,10 @@

#include <libxml/xpath.h>

#include <libxml/xpathInternals.h>

+#include "base/string_number_conversions.h"

#include "base/string_util.h"

#include "base/time.h"

-#include "chromeos/obsolete_logging.h"

+#include "base/logging.h"

#include "update_engine/action_pipe.h"

#include "update_engine/omaha_request_params.h"

#include "update_engine/prefs_interface.h"

@@ -294,9 +295,9 @@ bool UpdateLastPingDays(xmlDoc* doc, PrefsInterface* prefs) {

ConstXMLStr("elapsed_seconds")));

int64_t elapsed_seconds = 0;

- TEST_AND_RETURN_FALSE(StringToInt64(XmlGetProperty(daystart_node,

- "elapsed_seconds"),

- &elapsed_seconds));

+ TEST_AND_RETURN_FALSE(base::StringToInt64(XmlGetProperty(daystart_node,

+ "elapsed_seconds"),

+ &elapsed_seconds));

TEST_AND_RETURN_FALSE(elapsed_seconds >= 0);

// Remember the local time that matches the server's last midnight

« no previous file with comments | « omaha_hash_calculator.cc ('k') | prefs.cc » ('j') | no next file with comments »