Issue 3168012: Don't pass on --jobs to individual emerge processes in parallel_emerge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3168012: Don't pass on --jobs to individual emerge processes in parallel_emerge. (Closed)

Created:
10 years, 4 months ago by davidjames

Modified:
9 years, 4 months ago

Reviewers:
Nick Sanders

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@chromiumos-git/crosutils.git

Visibility:
Public.

Description

Don't pass on --jobs to individual emerge processes in parallel_emerge. When we pass on --jobs to individual emerge processes, it causes them to hide their output. This makes it harder to debug why they are failing or hanging. Example: http://goo.gl/C6Ru TEST=Made sure that output is shown by emerge processes when --jobs is used. BUG=chromium-os:5684

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add comments because Nick loves comments #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	parallel_emerge	View	1	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nick Sanders

10 years, 4 months ago (2010-08-13 20:29:38 UTC) #2

lgtm w/ comment

http://codereview.chromium.org/3168012/diff/1/2
File parallel_emerge (right):

http://codereview.chromium.org/3168012/diff/1/2#newcode1298
parallel_emerge:1298: emerge.opts.pop("--jobs", multiprocessing.cpu_count()))
can you add a comment here

Expand Messages | Collapse Messages