Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: parallel_emerge

Issue 3168012: Don't pass on --jobs to individual emerge processes in parallel_emerge. (Closed) Base URL: ssh://git@chromiumos-git/crosutils.git
Patch Set: Add comments because Nick loves comments Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: parallel_emerge
diff --git a/parallel_emerge b/parallel_emerge
index 3d5ad74205580edc4a3ead9c01ced4ba54703ca6..77e8f09b50aa4642bffbcedae570f12121680d41 100755
--- a/parallel_emerge
+++ b/parallel_emerge
@@ -1294,8 +1294,12 @@ class EmergeQueue(object):
# to help schedule jobs.
emerge.scheduler_graph = emerge.depgraph.schedulerGraph()
+ # Calculate how many jobs we can run in parallel. We don't want to pass
+ # the --jobs flag over to emerge itself, because that'll tell emerge to
+ # hide its output, and said output is quite useful for debugging hung
+ # jobs.
procs = min(self._total_jobs,
- emerge.opts.get("--jobs", multiprocessing.cpu_count()))
+ emerge.opts.pop("--jobs", multiprocessing.cpu_count()))
self._emerge_queue = multiprocessing.Queue()
self._job_queue = multiprocessing.Queue()
self._print_queue = multiprocessing.Queue()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698