Clamp the hotspot on custom cursors to the custom cursor image.

webkit/glue/webcursor_unittest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/pickle.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/WebKit/WebKit/chromium/public/WebCursorInfo.h"
 #include "webkit/glue/webcursor.h"
 #include "webkit/tools/test_shell/test_shell_test.h"
 
+using WebKit::WebCursorInfo;
+
 TEST(WebCursorTest, CursorSerialization) {
   WebCursor custom_cursor;
   // This is a valid custom cursor.
   Pickle ok_custom_pickle;
   // Type and hotspots.
   ok_custom_pickle.WriteInt(0);
   ok_custom_pickle.WriteInt(0);
   ok_custom_pickle.WriteInt(0);
   // X & Y
   ok_custom_pickle.WriteInt(1);
@@ skipping 53 matching lines @@
   neg_custom_pickle.WriteInt(-1);
   // Data len including enough data for a 1x1 image.
   neg_custom_pickle.WriteInt(4);
   neg_custom_pickle.WriteUInt32(0);
   // Custom Windows message.
   neg_custom_pickle.WriteUInt32(0);
   iter = NULL;
   EXPECT_FALSE(custom_cursor.Deserialize(&neg_custom_pickle, &iter));
 }
 
+TEST(WebCursorTest, ClampHotspot) {
+  WebCursor custom_cursor;
+  // This is a valid custom cursor.
+  Pickle ok_custom_pickle;
+  // Type and hotspots.
+  ok_custom_pickle.WriteInt(WebCursorInfo::TypeCustom);
+  // Hotspot is invalid --- outside the bounds of the image.
+  ok_custom_pickle.WriteInt(5);
+  ok_custom_pickle.WriteInt(5);
+  // X & Y
+  ok_custom_pickle.WriteInt(2);
+  ok_custom_pickle.WriteInt(2);
+  // Data len including enough data for a 2x2 image.
+  ok_custom_pickle.WriteInt(4 * 4);
+  for (size_t i = 0; i < 4; i++)
+    ok_custom_pickle.WriteUInt32(0);
+  // Custom Windows message.
+  ok_custom_pickle.WriteUInt32(0);
+  void* iter = NULL;
+  ASSERT_TRUE(custom_cursor.Deserialize(&ok_custom_pickle, &iter));

[Evan Martin, 2010/08/11 00:01:58]

yay correct usage of assert

+
+  // Convert to WebCursorInfo, make sure the hotspot got clamped.
+  WebCursorInfo info;
+  custom_cursor.GetCursorInfo(&info);
+  EXPECT_EQ(gfx::Point(1, 1), gfx::Point(info.hotSpot));
+
+  // Set hotspot to an invalid point again, pipe back through WebCursor,
+  // and make sure the hotspot got clamped again.
+  info.hotSpot = gfx::Point(-1, -1);
+  custom_cursor.InitFromCursorInfo(info);
+  custom_cursor.GetCursorInfo(&info);
+  EXPECT_EQ(gfx::Point(0, 0), gfx::Point(info.hotSpot));
+}