Issue 3166029: Store away breakpad symbols in debug.tgz

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3166029: Store away breakpad symbols in debug.tgz (Closed)

Created:
10 years, 4 months ago by kmixter1

Modified:
9 years, 7 months ago

Reviewers:
petkov, scottz-goog, scottz, djmm, Raja Aluri

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://src.chromium.org/git/crosutils.git

Visibility:
Public.

Description

Store away breakpad symbols in debug.tgz BUG=5355 Change-Id: I1f6dff3808c5bfaf4b7ed6ba75e4d19b196d749c

Patch Set 2 : Support uploading pre-generated breakpad symbols #

Patch Set 3 : Change default to not regenerate when uploading symbols #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -8 lines)			Patch
	M	archive_build.sh	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	upload_symbols	View	2	3 chunks	+18 lines, -8 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scottz-goog

LGTM, this just starts working right or is there something we need to add somewhere ...

10 years, 4 months ago (2010-08-24 22:20:31 UTC) #3

petkov

LGTM -- confirm that the change below is intentional. http://codereview.chromium.org/3166029/diff/6001/7002 File upload_symbols (right): http://codereview.chromium.org/3166029/diff/6001/7002#newcode115 upload_symbols:115: ...

10 years, 4 months ago (2010-08-24 22:58:18 UTC) #4

kmixter1

10 years, 4 months ago (2010-08-25 00:37:58 UTC) #5

petkov: Yes - intentional.  This is originally to avoid someone
accidentally uploading all the symbols.  Since that directory is only
now populated if you pass --regenerate, or if you knew to run
cros_generate_breakpad_symbols in advance, you won't be uploading
everything (or anything at all).

scottz: This should just start working.

On Tue, Aug 24, 2010 at 3:58 PM,  <petkov@chromium.org> wrote:
> LGTM -- confirm that the change below is intentional.
>
>
>
> http://codereview.chromium.org/3166029/diff/6001/7002
> File upload_symbols (right):
>
> http://codereview.chromium.org/3166029/diff/6001/7002#newcode115
> upload_symbols:115: really_upload || exit 1
> So you're asking the question only if regenerating, otherwise you go
> ahead and upload?
>
> http://codereview.chromium.org/3166029/show
>