Store away breakpad symbols in debug.tgz

upload_symbols

 #!/bin/bash
 # Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Script to upload all debug symbols required for crash reporting
 # purposes.  This script need only be used to upload release builds
 # symbols or to debug crashes on non-release builds (in which case try
 # to only upload the symbols for those executables involved).
 #
 # NOTE: This script must be run from the chromeos build chroot environment.
 #
 
 # Load common constants.  This should be the first executable line.
 # The path to common.sh should be relative to your script's location.
 . "$(dirname "$0")/common.sh"
 
 # Script must be run inside the chroot
 restart_in_chroot_if_needed $*
 
 get_default_board
 
 # Flags
 DEFINE_string board "$DEFAULT_BOARD" "The board to build packages for."
-DEFINE_boolean official_build $FLAGS_FALSE "Point to official symbol server."
-DEFINE_boolean regenerate $FLAGS_TRUE "Regenerate all symbols."
+DEFINE_string breakpad_root "" "Root directory for breakpad symbols."
+DEFINE_boolean official_build ${FLAGS_FALSE} "Point to official symbol server."
+DEFINE_boolean regenerate ${FLAGS_FALSE} "Regenerate all symbols."
 DEFINE_boolean verbose ${FLAGS_FALSE} "Be verbose."
 DEFINE_boolean yes ${FLAGS_FALSE} "Answer yes to all prompts."
 
 SYM_UPLOAD="sym_upload"
 
 ANY_ERRORS=0
 
 ERR_FILE=$(mktemp "/tmp/err.XXXX")
 
 function cleanup() {
@@ skipping 55 matching lines @@
 
   local upload_url=""
   if [ $FLAGS_official_build -eq $FLAGS_TRUE ]; then
     upload_url="http://clients2.google.com/cr/symbol"
   else
     upload_url="http://clients2.google.com/cr/staging_symbol"
     warn "This is an unofficial build, uploading to staging server."
   fi
   info "Uploading symbols to ${upload_url} from ${SYSROOT}."
 
-  MINIDUMP_SYMBOLS_ROOT="${SYSROOT}/usr/lib/debug/breakpad"
+  DEFAULT_BREAKPAD_ROOT="${SYSROOT}/usr/lib/debug/breakpad"
+  if [ -z "${FLAGS_breakpad_root}" ]; then
+    FLAGS_breakpad_root="${DEFAULT_BREAKPAD_ROOT}"
+  else
+    if [ ${FLAGS_regenerate} -eq ${FLAGS_TRUE} ]; then
+      warn "Assuming --noregenerate when --breakpad_root is specified"
+      FLAGS_regenerate=${FLAGS_FALSE}
+    fi
+  fi
 
   if [ -z "${FLAGS_ARGV}" ]; then
-    really_upload || exit 1
     if [ ${FLAGS_regenerate} -eq ${FLAGS_TRUE} ]; then
-      sudo rm -rf "${MINIDUMP_SYMBOLS_ROOT}"
-      info "Generating all minidump symbol files."
+      really_upload || exit 1

[petkov, 2010/08/24 22:58:18]

So you're asking the question only if regenerating, otherwise you go ahead and
upload?

+      info "Clearing ${DEFAULT_BREAKPAD_ROOT}"
+      sudo rm -rf "${DEFAULT_BREAKPAD_ROOT}"
+      info "Generating all breakpad symbol files."
       local verbosity=""
       local generate_script="$(dirname $0)/cros_generate_breakpad_symbols"
       [ ${FLAGS_verbose} -eq ${FLAGS_TRUE} ] && verbosity="--verbose"
       if ! "${generate_script}" --board=${FLAGS_board} ${verbosity}; then
         error "Some errors while generating symbols; uploading anyway"
         ANY_ERRORS=1
       fi
     fi
 
-    info "Uploading all minidump symbol files."
-    for sym_file in $(find "${MINIDUMP_SYMBOLS_ROOT}" -name \*.sym); do
+    info "Uploading all breakpad symbol files."
+    for sym_file in $(find "${FLAGS_breakpad_root}" -name \*.sym); do
       ! upload_file "${sym_file}" "${upload_url}"
     done
   else
     error "Unexpected args ${FLAGS_ARGV}"
   fi
 
   [ ${ANY_ERRORS} -ne 0 ] && die "Encountered problems"
   return 0
 }
 
 main "$@"