Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Issue 3166022: Properly convert the preferences label if it's not ASCII. (Closed)

Created:
10 years, 4 months ago by Mattias Nissler (ping if slow)
Modified:
9 years, 7 months ago
Reviewers:
tfarina
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

Properly convert the preferences label if it's not ASCII. BUG=52823 TEST=Configure arabic locale, fire up chrome, check the "Preferences" item in the wrench menu. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56878

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/wrench_menu_model.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mattias Nissler (ping if slow)
A tiny bugfix, please review.
10 years, 4 months ago (2010-08-20 09:22:58 UTC) #1
tfarina
10 years, 4 months ago (2010-08-20 13:49:14 UTC) #2
lgtm!

Powered by Google App Engine
This is Rietveld 408576698