chrome/browser/wrench_menu_model.cc - Issue 3166022: Properly convert the preferences label if it's not ASCII.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/wrench_menu_model.cc

Issue 3166022: Properly convert the preferences label if it's not ASCII. (Closed)

Patch Set: Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/wrench_menu_model.cc

diff --git a/chrome/browser/wrench_menu_model.cc b/chrome/browser/wrench_menu_model.cc

index 8dd51e4a25f95d61eba82e4ef7c9688056422661..8a52c9ddb17059b36b6376524b04bb3f0838a878 100644

--- a/chrome/browser/wrench_menu_model.cc

+++ b/chrome/browser/wrench_menu_model.cc

@@ -324,7 +324,7 @@ void WrenchMenuModel::Build() {

if (gtk_stock_lookup(GTK_STOCK_PREFERENCES, &stock_item)) {

const char16 kUnderscore[] = { '_', 0 };

string16 preferences;

- RemoveChars(ASCIIToUTF16(stock_item.label), kUnderscore, &preferences);

+ RemoveChars(UTF8ToUTF16(stock_item.label), kUnderscore, &preferences);

AddItem(IDC_OPTIONS, preferences);

}

#else

« no previous file with comments | « no previous file | no next file » | no next file with comments »