Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1113)

Unified Diff: net/http/http_stream_request.cc

Issue 3165057: Remove two CHECKs that were added to help track down the crash... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/socket/ssl_client_socket_nss.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_request.cc
===================================================================
--- net/http/http_stream_request.cc (revision 57134)
+++ net/http/http_stream_request.cc (working copy)
@@ -36,7 +36,7 @@
return original_url.ReplaceComponents(replacements);
}
-}
+} // namespace
vandebo (ex-Chrome) 2010/08/24 19:59:35 Is this an intentional change?
wtc 2010/08/24 22:40:18 Yes, I ran cpplint.py on the whole file and it war
HttpStreamRequest::HttpStreamRequest(
HttpStreamFactory* factory,
@@ -620,11 +620,8 @@
return OK;
}
- if (result < 0 && !ssl_started) {
- // A temporary CHECK for tracking down http://crbug.com/49862.
- CHECK(!IsCertificateError(result));
+ if (result < 0 && !ssl_started)
return ReconsiderProxyAfterError(result);
- }
establishing_tunnel_ = false;
if (connection_->socket()) {
« no previous file with comments | « no previous file | net/socket/ssl_client_socket_nss.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698