Remove two CHECKs that were added to help track down the crash...

net/http/http_stream_request.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_stream_request.h"
 
 #include "base/stl_util-inl.h"
 #include "base/string_number_conversions.h"
 #include "base/string_util.h"
 #include "net/base/connection_type_histograms.h"
@@ skipping 18 matching lines @@
   GURL::Replacements replacements;
   // new_sheme and new_port need to be in scope here because GURL::Replacements
   // references the memory contained by them directly.
   const std::string new_scheme = "https";
   const std::string new_port = base::IntToString(443);
   replacements.SetSchemeStr(new_scheme);
   replacements.SetPortStr(new_port);
   return original_url.ReplaceComponents(replacements);
 }
 
-}
+}  // namespace

[vandebo (ex-Chrome), 2010/08/24 19:59:35]

Is this an intentional change?

[wtc, 2010/08/24 22:40:18]

Yes, I ran cpplint.py on the whole file and it warned about
this line.  I will clarify this in the CL's description.

 
 HttpStreamRequest::HttpStreamRequest(
     HttpStreamFactory* factory,
     const scoped_refptr<HttpNetworkSession>& session)
     : request_info_(NULL),
       proxy_info_(NULL),
       ssl_config_(NULL),
       session_(session),
       ALLOW_THIS_IN_INITIALIZER_LIST(
           io_callback_(this, &HttpStreamRequest::OnIOComplete)),
@@ skipping 563 matching lines @@
   }
 
   if ((!ssl_started && result < 0 &&
        alternate_protocol_mode_ == kUsingAlternateProtocol) ||
       result == ERR_NPN_NEGOTIATION_FAILED) {
     // Mark the alternate protocol as broken and fallback.
     MarkBrokenAlternateProtocolAndFallback();
     return OK;
   }
 
-  if (result < 0 && !ssl_started) {
-    // A temporary CHECK for tracking down http://crbug.com/49862.
-    CHECK(!IsCertificateError(result));
+  if (result < 0 && !ssl_started)
     return ReconsiderProxyAfterError(result);
-  }
   establishing_tunnel_ = false;
 
   if (connection_->socket()) {
     LogHttpConnectedMetrics(*connection_);
 
     // We officially have a new connection.  Record the type.
     if (!connection_->is_reused()) {
       ConnectionType type = using_spdy_ ? CONNECTION_SPDY : CONNECTION_HTTP;
       UpdateConnectionTypeHistograms(type);
     }
@@ skipping 274 matching lines @@
                                  100);
       break;
     default:
       NOTREACHED();
       break;
   }
 }
 
 }  // namespace net