Issue 3165057: Remove two CHECKs that were added to help track down the crash...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3165057: Remove two CHECKs that were added to help track down the crash... (Closed)

Created:
10 years, 4 months ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
vandebo (ex-Chrome)

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove two CHECKs that were added to help track down the crash in http://crbug.com/49862. That crash no longer occurs. Fix cpplint.py nit: add a "// namespace" comment. R=vandebo BUG=49862 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57250

Patch Set 1 #

Total comments: 2

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -7 lines)			Patch
	M	net/http/http_stream_request.cc	View		2 chunks	+2 lines, -5 lines	2 comments	Download
	M	net/socket/ssl_client_socket_nss.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

vandebo (ex-Chrome)

LGTM http://codereview.chromium.org/3165057/diff/1/2 File net/http/http_stream_request.cc (right): http://codereview.chromium.org/3165057/diff/1/2#newcode39 net/http/http_stream_request.cc:39: } // namespace Is this an intentional change?

10 years, 4 months ago (2010-08-24 19:59:35 UTC) #2

wtc

10 years, 4 months ago (2010-08-24 22:40:18 UTC) #3

http://codereview.chromium.org/3165057/diff/1/2
File net/http/http_stream_request.cc (right):

http://codereview.chromium.org/3165057/diff/1/2#newcode39
net/http/http_stream_request.cc:39: }  // namespace
On 2010/08/24 19:59:35, vandebo wrote:
> Is this an intentional change?

Yes, I ran cpplint.py on the whole file and it warned about
this line.  I will clarify this in the CL's description.

Expand Messages | Collapse Messages