Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: chrome/browser/chromeos/login/network_screen_browsertest.cc

Issue 3159031: Remove wstrings from bookmarks, part 12. (Closed)
Patch Set: rebased ToT Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/network_screen_browsertest.cc
diff --git a/chrome/browser/chromeos/login/network_screen_browsertest.cc b/chrome/browser/chromeos/login/network_screen_browsertest.cc
index 5bcbedc57bfc26b0be3c98333ddf8b398442bf2b..8e52bd4b02ca90dd88aa417109db1964ecf56e11 100644
--- a/chrome/browser/chromeos/login/network_screen_browsertest.cc
+++ b/chrome/browser/chromeos/login/network_screen_browsertest.cc
@@ -8,6 +8,7 @@
#include "app/l10n_util.h"
#include "base/message_loop.h"
#include "base/scoped_ptr.h"
+#include "base/string16.h"
#include "base/string_number_conversions.h"
#include "base/utf_string_conversions.h"
#include "chrome/browser/chromeos/cros/cros_library.h"
@@ -47,8 +48,8 @@ class DummyComboboxModel : public ComboboxModel {
public:
virtual int GetItemCount() { return 2; }
- virtual std::wstring GetItemAt(int index) {
- return L"Item " + UTF16ToWideHack(base::IntToString16(index));
+ virtual string16 GetItemAt(int index) {
+ return ASCIIToUTF16("Item ") + base::IntToString16(index);
}
};
@@ -208,7 +209,7 @@ IN_PROC_BROWSER_TEST_F(NetworkScreenTest, Basic) {
NetworkSelectionView* network_view = network_screen->view();
ASSERT_TRUE(network_view != NULL);
ASSERT_EQ(1, network_screen->GetItemCount());
- EXPECT_EQ(l10n_util::GetString(IDS_STATUSBAR_NO_NETWORKS_MESSAGE),
+ EXPECT_EQ(l10n_util::GetStringUTF16(IDS_STATUSBAR_NO_NETWORKS_MESSAGE),
network_screen->GetItemAt(0));
}
@@ -228,10 +229,10 @@ IN_PROC_BROWSER_TEST_F(NetworkScreenTest, EnableWifi) {
WifiCellularNetworksExpectations();
network_screen->NetworkChanged(network_library);
ASSERT_EQ(2, network_screen->GetItemCount());
- EXPECT_EQ(l10n_util::GetString(IDS_STATUSBAR_NO_NETWORKS_MESSAGE),
+ EXPECT_EQ(l10n_util::GetStringUTF16(IDS_STATUSBAR_NO_NETWORKS_MESSAGE),
network_screen->GetItemAt(0));
- EXPECT_EQ(l10n_util::GetStringF(IDS_STATUSBAR_NETWORK_DEVICE_ENABLE,
- l10n_util::GetString(IDS_STATUSBAR_NETWORK_DEVICE_WIFI)),
+ EXPECT_EQ(l10n_util::GetStringFUTF16(IDS_STATUSBAR_NETWORK_DEVICE_ENABLE,
+ l10n_util::GetStringUTF16(IDS_STATUSBAR_NETWORK_DEVICE_WIFI)),
network_screen->GetItemAt(1));
// Emulate "Enable Wifi" item press.
@@ -262,7 +263,7 @@ IN_PROC_BROWSER_TEST_F(NetworkScreenTest, NetworksConnectedNotSelected) {
EXPECT_EQ(1, network_view->GetSelectedNetworkItem());
ASSERT_EQ(network_screen, controller()->current_screen());
ASSERT_EQ(2, network_screen->GetItemCount());
- EXPECT_EQ(l10n_util::GetString(IDS_STATUSBAR_NETWORK_DEVICE_ETHERNET),
+ EXPECT_EQ(l10n_util::GetStringUTF16(IDS_STATUSBAR_NETWORK_DEVICE_ETHERNET),
network_screen->GetItemAt(1));
// Ethernet - disconnected, WiFi & Cellular - connected.
@@ -278,8 +279,8 @@ IN_PROC_BROWSER_TEST_F(NetworkScreenTest, NetworksConnectedNotSelected) {
network_screen->NetworkChanged(network_library);
ASSERT_EQ(network_screen, controller()->current_screen());
ASSERT_EQ(3, network_screen->GetItemCount());
- EXPECT_EQ(ASCIIToWide(wifi_.name()), network_screen->GetItemAt(1));
- EXPECT_EQ(ASCIIToWide(cellular_.name()), network_screen->GetItemAt(2));
+ EXPECT_EQ(ASCIIToUTF16(wifi_.name()), network_screen->GetItemAt(1));
+ EXPECT_EQ(ASCIIToUTF16(cellular_.name()), network_screen->GetItemAt(2));
// Ethernet, WiFi & Cellular - connected.
EthernetExpectations(true, false);
@@ -292,10 +293,10 @@ IN_PROC_BROWSER_TEST_F(NetworkScreenTest, NetworksConnectedNotSelected) {
network_screen->NetworkChanged(network_library);
ASSERT_EQ(network_screen, controller()->current_screen());
ASSERT_EQ(4, network_screen->GetItemCount());
- EXPECT_EQ(l10n_util::GetString(IDS_STATUSBAR_NETWORK_DEVICE_ETHERNET),
+ EXPECT_EQ(l10n_util::GetStringUTF16(IDS_STATUSBAR_NETWORK_DEVICE_ETHERNET),
network_screen->GetItemAt(1));
- EXPECT_EQ(ASCIIToWide(wifi_.name()), network_screen->GetItemAt(2));
- EXPECT_EQ(ASCIIToWide(cellular_.name()), network_screen->GetItemAt(3));
+ EXPECT_EQ(ASCIIToUTF16(wifi_.name()), network_screen->GetItemAt(2));
+ EXPECT_EQ(ASCIIToUTF16(cellular_.name()), network_screen->GetItemAt(3));
// Ethernet is only preselected once.
EXPECT_EQ(0, network_view->GetSelectedNetworkItem());
}
@@ -315,7 +316,7 @@ IN_PROC_BROWSER_TEST_F(NetworkScreenTest, EthernetSelected) {
NetworkChangedExpectations(true);
network_screen->NetworkChanged(network_library);
ASSERT_EQ(2, network_screen->GetItemCount());
- EXPECT_EQ(l10n_util::GetString(IDS_STATUSBAR_NETWORK_DEVICE_ETHERNET),
+ EXPECT_EQ(l10n_util::GetStringUTF16(IDS_STATUSBAR_NETWORK_DEVICE_ETHERNET),
network_screen->GetItemAt(1));
ASSERT_EQ(network_screen, controller()->current_screen());
@@ -356,7 +357,7 @@ IN_PROC_BROWSER_TEST_F(NetworkScreenTest, WifiSelected) {
NetworkChangedExpectations(true);
network_screen->NetworkChanged(network_library);
ASSERT_EQ(2, network_screen->GetItemCount());
- EXPECT_EQ(ASCIIToWide(wifi_.name()), network_screen->GetItemAt(1));
+ EXPECT_EQ(ASCIIToUTF16(wifi_.name()), network_screen->GetItemAt(1));
DummyComboboxModel combobox_model;
views::Combobox combobox(&combobox_model);
@@ -417,7 +418,7 @@ IN_PROC_BROWSER_TEST_F(NetworkScreenTest, CellularSelected) {
NetworkChangedExpectations(true);
network_screen->NetworkChanged(network_library);
ASSERT_EQ(2, network_screen->GetItemCount());
- EXPECT_EQ(ASCIIToWide(cellular_.name()), network_screen->GetItemAt(1));
+ EXPECT_EQ(ASCIIToUTF16(cellular_.name()), network_screen->GetItemAt(1));
DummyComboboxModel combobox_model;
views::Combobox combobox(&combobox_model);
« no previous file with comments | « chrome/browser/chromeos/login/network_screen.cc ('k') | chrome/browser/chromeos/options/language_config_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698