Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: chrome/browser/chromeos/login/network_screen_browsertest.cc

Issue 3159031: Remove wstrings from bookmarks, part 12. (Closed)
Patch Set: rebased ToT Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "app/combobox_model.h" 7 #include "app/combobox_model.h"
8 #include "app/l10n_util.h" 8 #include "app/l10n_util.h"
9 #include "base/message_loop.h" 9 #include "base/message_loop.h"
10 #include "base/scoped_ptr.h" 10 #include "base/scoped_ptr.h"
11 #include "base/string16.h"
11 #include "base/string_number_conversions.h" 12 #include "base/string_number_conversions.h"
12 #include "base/utf_string_conversions.h" 13 #include "base/utf_string_conversions.h"
13 #include "chrome/browser/chromeos/cros/cros_library.h" 14 #include "chrome/browser/chromeos/cros/cros_library.h"
14 #include "chrome/browser/chromeos/cros/mock_login_library.h" 15 #include "chrome/browser/chromeos/cros/mock_login_library.h"
15 #include "chrome/browser/chromeos/cros/mock_network_library.h" 16 #include "chrome/browser/chromeos/cros/mock_network_library.h"
16 #include "chrome/browser/chromeos/cros/network_library.h" 17 #include "chrome/browser/chromeos/cros/network_library.h"
17 #include "chrome/browser/chromeos/login/network_selection_view.h" 18 #include "chrome/browser/chromeos/login/network_selection_view.h"
18 #include "chrome/browser/chromeos/login/network_screen.h" 19 #include "chrome/browser/chromeos/login/network_screen.h"
19 #include "chrome/browser/chromeos/login/mock_screen_observer.h" 20 #include "chrome/browser/chromeos/login/mock_screen_observer.h"
20 #include "chrome/browser/chromeos/login/view_screen.h" 21 #include "chrome/browser/chromeos/login/view_screen.h"
(...skipping 19 matching lines...) Expand all
40 class DummyButtonListener : public views::ButtonListener { 41 class DummyButtonListener : public views::ButtonListener {
41 public: 42 public:
42 virtual void ButtonPressed(views::Button* sender, 43 virtual void ButtonPressed(views::Button* sender,
43 const views::Event& event) {} 44 const views::Event& event) {}
44 }; 45 };
45 46
46 class DummyComboboxModel : public ComboboxModel { 47 class DummyComboboxModel : public ComboboxModel {
47 public: 48 public:
48 virtual int GetItemCount() { return 2; } 49 virtual int GetItemCount() { return 2; }
49 50
50 virtual std::wstring GetItemAt(int index) { 51 virtual string16 GetItemAt(int index) {
51 return L"Item " + UTF16ToWideHack(base::IntToString16(index)); 52 return ASCIIToUTF16("Item ") + base::IntToString16(index);
52 } 53 }
53 }; 54 };
54 55
55 class NetworkScreenTest : public WizardInProcessBrowserTest { 56 class NetworkScreenTest : public WizardInProcessBrowserTest {
56 public: 57 public:
57 NetworkScreenTest(): WizardInProcessBrowserTest("network"), 58 NetworkScreenTest(): WizardInProcessBrowserTest("network"),
58 mock_login_library_(NULL), 59 mock_login_library_(NULL),
59 mock_network_library_(NULL) { 60 mock_network_library_(NULL) {
60 cellular_.set_name("Cellular network"); 61 cellular_.set_name("Cellular network");
61 wifi_.set_name("WiFi network"); 62 wifi_.set_name("WiFi network");
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 202
202 IN_PROC_BROWSER_TEST_F(NetworkScreenTest, Basic) { 203 IN_PROC_BROWSER_TEST_F(NetworkScreenTest, Basic) {
203 ASSERT_TRUE(controller()); 204 ASSERT_TRUE(controller());
204 NetworkScreen* network_screen = controller()->GetNetworkScreen(); 205 NetworkScreen* network_screen = controller()->GetNetworkScreen();
205 ASSERT_TRUE(network_screen != NULL); 206 ASSERT_TRUE(network_screen != NULL);
206 ASSERT_EQ(network_screen, controller()->current_screen()); 207 ASSERT_EQ(network_screen, controller()->current_screen());
207 208
208 NetworkSelectionView* network_view = network_screen->view(); 209 NetworkSelectionView* network_view = network_screen->view();
209 ASSERT_TRUE(network_view != NULL); 210 ASSERT_TRUE(network_view != NULL);
210 ASSERT_EQ(1, network_screen->GetItemCount()); 211 ASSERT_EQ(1, network_screen->GetItemCount());
211 EXPECT_EQ(l10n_util::GetString(IDS_STATUSBAR_NO_NETWORKS_MESSAGE), 212 EXPECT_EQ(l10n_util::GetStringUTF16(IDS_STATUSBAR_NO_NETWORKS_MESSAGE),
212 network_screen->GetItemAt(0)); 213 network_screen->GetItemAt(0));
213 } 214 }
214 215
215 IN_PROC_BROWSER_TEST_F(NetworkScreenTest, EnableWifi) { 216 IN_PROC_BROWSER_TEST_F(NetworkScreenTest, EnableWifi) {
216 ASSERT_TRUE(controller()); 217 ASSERT_TRUE(controller());
217 NetworkScreen* network_screen = controller()->GetNetworkScreen(); 218 NetworkScreen* network_screen = controller()->GetNetworkScreen();
218 ASSERT_TRUE(network_screen != NULL); 219 ASSERT_TRUE(network_screen != NULL);
219 ASSERT_EQ(network_screen, controller()->current_screen()); 220 ASSERT_EQ(network_screen, controller()->current_screen());
220 NetworkSelectionView* network_view = network_screen->view(); 221 NetworkSelectionView* network_view = network_screen->view();
221 ASSERT_TRUE(network_view != NULL); 222 ASSERT_TRUE(network_view != NULL);
222 NetworkLibrary* network_library = 223 NetworkLibrary* network_library =
223 chromeos::CrosLibrary::Get()->GetNetworkLibrary(); 224 chromeos::CrosLibrary::Get()->GetNetworkLibrary();
224 225
225 // WiFi is disabled. 226 // WiFi is disabled.
226 NetworkChangedExpectations(false); 227 NetworkChangedExpectations(false);
227 EthernetExpectations(false, false); 228 EthernetExpectations(false, false);
228 WifiCellularNetworksExpectations(); 229 WifiCellularNetworksExpectations();
229 network_screen->NetworkChanged(network_library); 230 network_screen->NetworkChanged(network_library);
230 ASSERT_EQ(2, network_screen->GetItemCount()); 231 ASSERT_EQ(2, network_screen->GetItemCount());
231 EXPECT_EQ(l10n_util::GetString(IDS_STATUSBAR_NO_NETWORKS_MESSAGE), 232 EXPECT_EQ(l10n_util::GetStringUTF16(IDS_STATUSBAR_NO_NETWORKS_MESSAGE),
232 network_screen->GetItemAt(0)); 233 network_screen->GetItemAt(0));
233 EXPECT_EQ(l10n_util::GetStringF(IDS_STATUSBAR_NETWORK_DEVICE_ENABLE, 234 EXPECT_EQ(l10n_util::GetStringFUTF16(IDS_STATUSBAR_NETWORK_DEVICE_ENABLE,
234 l10n_util::GetString(IDS_STATUSBAR_NETWORK_DEVICE_WIFI)), 235 l10n_util::GetStringUTF16(IDS_STATUSBAR_NETWORK_DEVICE_WIFI)),
235 network_screen->GetItemAt(1)); 236 network_screen->GetItemAt(1));
236 237
237 // Emulate "Enable Wifi" item press. 238 // Emulate "Enable Wifi" item press.
238 EXPECT_CALL(*mock_network_library_, EnableWifiNetworkDevice(true)) 239 EXPECT_CALL(*mock_network_library_, EnableWifiNetworkDevice(true))
239 .Times(1); 240 .Times(1);
240 DummyComboboxModel combobox_model; 241 DummyComboboxModel combobox_model;
241 views::Combobox combobox(&combobox_model); 242 views::Combobox combobox(&combobox_model);
242 network_screen->ItemChanged(&combobox, 0, 1); 243 network_screen->ItemChanged(&combobox, 0, 1);
243 network_view->SetSelectedNetworkItem(1); 244 network_view->SetSelectedNetworkItem(1);
244 ui_test_utils::RunAllPendingInMessageLoop(); 245 ui_test_utils::RunAllPendingInMessageLoop();
(...skipping 10 matching lines...) Expand all
255 ASSERT_TRUE(network_view != NULL); 256 ASSERT_TRUE(network_view != NULL);
256 257
257 EthernetExpectations(true, false); 258 EthernetExpectations(true, false);
258 WifiCellularNetworksExpectations(); 259 WifiCellularNetworksExpectations();
259 NetworkChangedExpectations(true); 260 NetworkChangedExpectations(true);
260 network_screen->NetworkChanged(network_library); 261 network_screen->NetworkChanged(network_library);
261 // Ethernet is preselected once. 262 // Ethernet is preselected once.
262 EXPECT_EQ(1, network_view->GetSelectedNetworkItem()); 263 EXPECT_EQ(1, network_view->GetSelectedNetworkItem());
263 ASSERT_EQ(network_screen, controller()->current_screen()); 264 ASSERT_EQ(network_screen, controller()->current_screen());
264 ASSERT_EQ(2, network_screen->GetItemCount()); 265 ASSERT_EQ(2, network_screen->GetItemCount());
265 EXPECT_EQ(l10n_util::GetString(IDS_STATUSBAR_NETWORK_DEVICE_ETHERNET), 266 EXPECT_EQ(l10n_util::GetStringUTF16(IDS_STATUSBAR_NETWORK_DEVICE_ETHERNET),
266 network_screen->GetItemAt(1)); 267 network_screen->GetItemAt(1));
267 268
268 // Ethernet - disconnected, WiFi & Cellular - connected. 269 // Ethernet - disconnected, WiFi & Cellular - connected.
269 EthernetExpectations(false, false); 270 EthernetExpectations(false, false);
270 SetupWifiNetwork(true, false); 271 SetupWifiNetwork(true, false);
271 WifiExpectations(true, false); 272 WifiExpectations(true, false);
272 SetupCellularNetwork(true, false); 273 SetupCellularNetwork(true, false);
273 CellularExpectations(true, false); 274 CellularExpectations(true, false);
274 WifiCellularNetworksExpectations(); 275 WifiCellularNetworksExpectations();
275 WifiSsidExpectation(wifi_.name()); 276 WifiSsidExpectation(wifi_.name());
276 CellularNameExpectation(cellular_.name()); 277 CellularNameExpectation(cellular_.name());
277 NetworkChangedExpectations(true); 278 NetworkChangedExpectations(true);
278 network_screen->NetworkChanged(network_library); 279 network_screen->NetworkChanged(network_library);
279 ASSERT_EQ(network_screen, controller()->current_screen()); 280 ASSERT_EQ(network_screen, controller()->current_screen());
280 ASSERT_EQ(3, network_screen->GetItemCount()); 281 ASSERT_EQ(3, network_screen->GetItemCount());
281 EXPECT_EQ(ASCIIToWide(wifi_.name()), network_screen->GetItemAt(1)); 282 EXPECT_EQ(ASCIIToUTF16(wifi_.name()), network_screen->GetItemAt(1));
282 EXPECT_EQ(ASCIIToWide(cellular_.name()), network_screen->GetItemAt(2)); 283 EXPECT_EQ(ASCIIToUTF16(cellular_.name()), network_screen->GetItemAt(2));
283 284
284 // Ethernet, WiFi & Cellular - connected. 285 // Ethernet, WiFi & Cellular - connected.
285 EthernetExpectations(true, false); 286 EthernetExpectations(true, false);
286 WifiExpectations(true, false); 287 WifiExpectations(true, false);
287 CellularExpectations(true, false); 288 CellularExpectations(true, false);
288 WifiCellularNetworksExpectations(); 289 WifiCellularNetworksExpectations();
289 WifiSsidExpectation(wifi_.name()); 290 WifiSsidExpectation(wifi_.name());
290 CellularNameExpectation(cellular_.name()); 291 CellularNameExpectation(cellular_.name());
291 NetworkChangedExpectations(true); 292 NetworkChangedExpectations(true);
292 network_screen->NetworkChanged(network_library); 293 network_screen->NetworkChanged(network_library);
293 ASSERT_EQ(network_screen, controller()->current_screen()); 294 ASSERT_EQ(network_screen, controller()->current_screen());
294 ASSERT_EQ(4, network_screen->GetItemCount()); 295 ASSERT_EQ(4, network_screen->GetItemCount());
295 EXPECT_EQ(l10n_util::GetString(IDS_STATUSBAR_NETWORK_DEVICE_ETHERNET), 296 EXPECT_EQ(l10n_util::GetStringUTF16(IDS_STATUSBAR_NETWORK_DEVICE_ETHERNET),
296 network_screen->GetItemAt(1)); 297 network_screen->GetItemAt(1));
297 EXPECT_EQ(ASCIIToWide(wifi_.name()), network_screen->GetItemAt(2)); 298 EXPECT_EQ(ASCIIToUTF16(wifi_.name()), network_screen->GetItemAt(2));
298 EXPECT_EQ(ASCIIToWide(cellular_.name()), network_screen->GetItemAt(3)); 299 EXPECT_EQ(ASCIIToUTF16(cellular_.name()), network_screen->GetItemAt(3));
299 // Ethernet is only preselected once. 300 // Ethernet is only preselected once.
300 EXPECT_EQ(0, network_view->GetSelectedNetworkItem()); 301 EXPECT_EQ(0, network_view->GetSelectedNetworkItem());
301 } 302 }
302 303
303 IN_PROC_BROWSER_TEST_F(NetworkScreenTest, EthernetSelected) { 304 IN_PROC_BROWSER_TEST_F(NetworkScreenTest, EthernetSelected) {
304 ASSERT_TRUE(controller()); 305 ASSERT_TRUE(controller());
305 NetworkLibrary* network_library = 306 NetworkLibrary* network_library =
306 chromeos::CrosLibrary::Get()->GetNetworkLibrary(); 307 chromeos::CrosLibrary::Get()->GetNetworkLibrary();
307 NetworkScreen* network_screen = controller()->GetNetworkScreen(); 308 NetworkScreen* network_screen = controller()->GetNetworkScreen();
308 ASSERT_TRUE(network_screen != NULL); 309 ASSERT_TRUE(network_screen != NULL);
309 NetworkSelectionView* network_view = network_screen->view(); 310 NetworkSelectionView* network_view = network_screen->view();
310 ASSERT_TRUE(network_view != NULL); 311 ASSERT_TRUE(network_view != NULL);
311 312
312 // Emulate connecting to Ethernet. 313 // Emulate connecting to Ethernet.
313 EthernetExpectations(false, true); 314 EthernetExpectations(false, true);
314 WifiCellularNetworksExpectations(); 315 WifiCellularNetworksExpectations();
315 NetworkChangedExpectations(true); 316 NetworkChangedExpectations(true);
316 network_screen->NetworkChanged(network_library); 317 network_screen->NetworkChanged(network_library);
317 ASSERT_EQ(2, network_screen->GetItemCount()); 318 ASSERT_EQ(2, network_screen->GetItemCount());
318 EXPECT_EQ(l10n_util::GetString(IDS_STATUSBAR_NETWORK_DEVICE_ETHERNET), 319 EXPECT_EQ(l10n_util::GetStringUTF16(IDS_STATUSBAR_NETWORK_DEVICE_ETHERNET),
319 network_screen->GetItemAt(1)); 320 network_screen->GetItemAt(1));
320 ASSERT_EQ(network_screen, controller()->current_screen()); 321 ASSERT_EQ(network_screen, controller()->current_screen());
321 322
322 // Emulate combobox selection - nothing happens. 323 // Emulate combobox selection - nothing happens.
323 DummyComboboxModel combobox_model; 324 DummyComboboxModel combobox_model;
324 views::Combobox combobox(&combobox_model); 325 views::Combobox combobox(&combobox_model);
325 network_screen->ItemChanged(&combobox, 0, 1); 326 network_screen->ItemChanged(&combobox, 0, 1);
326 network_view->SetSelectedNetworkItem(1); 327 network_view->SetSelectedNetworkItem(1);
327 ui_test_utils::RunAllPendingInMessageLoop(); 328 ui_test_utils::RunAllPendingInMessageLoop();
328 ASSERT_EQ(network_screen, controller()->current_screen()); 329 ASSERT_EQ(network_screen, controller()->current_screen());
(...skipping 20 matching lines...) Expand all
349 NetworkSelectionView* network_view = network_screen->view(); 350 NetworkSelectionView* network_view = network_screen->view();
350 ASSERT_TRUE(network_view != NULL); 351 ASSERT_TRUE(network_view != NULL);
351 352
352 EthernetExpectations(false, false); 353 EthernetExpectations(false, false);
353 SetupWifiNetwork(false, false); 354 SetupWifiNetwork(false, false);
354 WifiCellularNetworksExpectations(); 355 WifiCellularNetworksExpectations();
355 WifiSsidExpectation(std::string()); 356 WifiSsidExpectation(std::string());
356 NetworkChangedExpectations(true); 357 NetworkChangedExpectations(true);
357 network_screen->NetworkChanged(network_library); 358 network_screen->NetworkChanged(network_library);
358 ASSERT_EQ(2, network_screen->GetItemCount()); 359 ASSERT_EQ(2, network_screen->GetItemCount());
359 EXPECT_EQ(ASCIIToWide(wifi_.name()), network_screen->GetItemAt(1)); 360 EXPECT_EQ(ASCIIToUTF16(wifi_.name()), network_screen->GetItemAt(1));
360 361
361 DummyComboboxModel combobox_model; 362 DummyComboboxModel combobox_model;
362 views::Combobox combobox(&combobox_model); 363 views::Combobox combobox(&combobox_model);
363 364
364 // Emulate combobox selection. 365 // Emulate combobox selection.
365 EthernetExpectations(false, false); 366 EthernetExpectations(false, false);
366 WifiCellularNetworksExpectations(); 367 WifiCellularNetworksExpectations();
367 WifiSsidExpectation(std::string()); 368 WifiSsidExpectation(std::string());
368 network_screen->ItemChanged(&combobox, 0, 1); 369 network_screen->ItemChanged(&combobox, 0, 1);
369 network_view->SetSelectedNetworkItem(1); 370 network_view->SetSelectedNetworkItem(1);
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
410 NetworkSelectionView* network_view = network_screen->view(); 411 NetworkSelectionView* network_view = network_screen->view();
411 ASSERT_TRUE(network_view != NULL); 412 ASSERT_TRUE(network_view != NULL);
412 413
413 EthernetExpectations(false, false); 414 EthernetExpectations(false, false);
414 SetupCellularNetwork(false, false); 415 SetupCellularNetwork(false, false);
415 WifiCellularNetworksExpectations(); 416 WifiCellularNetworksExpectations();
416 CellularNameExpectation(std::string()); 417 CellularNameExpectation(std::string());
417 NetworkChangedExpectations(true); 418 NetworkChangedExpectations(true);
418 network_screen->NetworkChanged(network_library); 419 network_screen->NetworkChanged(network_library);
419 ASSERT_EQ(2, network_screen->GetItemCount()); 420 ASSERT_EQ(2, network_screen->GetItemCount());
420 EXPECT_EQ(ASCIIToWide(cellular_.name()), network_screen->GetItemAt(1)); 421 EXPECT_EQ(ASCIIToUTF16(cellular_.name()), network_screen->GetItemAt(1));
421 422
422 DummyComboboxModel combobox_model; 423 DummyComboboxModel combobox_model;
423 views::Combobox combobox(&combobox_model); 424 views::Combobox combobox(&combobox_model);
424 425
425 // Emulate combobox selection. 426 // Emulate combobox selection.
426 EthernetExpectations(false, false); 427 EthernetExpectations(false, false);
427 WifiCellularNetworksExpectations(); 428 WifiCellularNetworksExpectations();
428 CellularNameExpectation(std::string()); 429 CellularNameExpectation(std::string());
429 network_screen->ItemChanged(&combobox, 0, 1); 430 network_screen->ItemChanged(&combobox, 0, 1);
430 network_view->SetSelectedNetworkItem(1); 431 network_view->SetSelectedNetworkItem(1);
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
525 WifiExpectations(true, false); 526 WifiExpectations(true, false);
526 WifiCellularNetworksExpectations(); 527 WifiCellularNetworksExpectations();
527 WifiSsidExpectation(wifi_.name()); 528 WifiSsidExpectation(wifi_.name());
528 NetworkChangedExpectations(true); 529 NetworkChangedExpectations(true);
529 network_screen->NetworkChanged(network_library); 530 network_screen->NetworkChanged(network_library);
530 ui_test_utils::RunAllPendingInMessageLoop(); 531 ui_test_utils::RunAllPendingInMessageLoop();
531 controller()->set_observer(NULL); 532 controller()->set_observer(NULL);
532 } 533 }
533 534
534 } // namespace chromeos 535 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/login/network_screen.cc ('k') | chrome/browser/chromeos/options/language_config_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698