Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 3159031: Remove wstrings from bookmarks, part 12. (Closed)

Created:
10 years, 4 months ago by viettrungluu
Modified:
9 years, 6 months ago
CC:
chromium-reviews, dhollowa, Paweł Hajdan Jr., nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Remove wstrings from bookmarks, part 12. - This changes RecentlyUsedFoldersComboModel::GetItemAt() to return a string16 instead of a wstring. - This entailed changing the base class, ComboboxModel, and shaving a herd of yaks. BUG=23581 TEST=builds and passes tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57021

Patch Set 1 #

Patch Set 2 : oops #

Patch Set 3 : rebased ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -115 lines) Patch
M app/combobox_model.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/bookmarks/recently_used_folders_combo_model.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/recently_used_folders_combo_model.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/network_screen.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/network_screen.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/network_screen_browsertest.cc View 10 chunks +16 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/options/language_config_model.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/options/language_config_model.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/options/language_config_model_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/options/language_config_util.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/options/language_hangul_config_view.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/options/system_page_view.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/content_setting_combo_model.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/content_setting_combo_model.cc View 1 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/default_encoding_combo_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/default_encoding_combo_model.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/gtk/bookmark_bubble_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/options/content_exception_editor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/options/fonts_page_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/options/languages_page_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/language_combobox_model.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/language_combobox_model.cc View 2 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/views/autofill_profiles_view_win.h View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/views/autofill_profiles_view_win.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/views/clear_browsing_data.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/clear_browsing_data.cc View 2 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/views/cookie_info_view.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/views/cookie_info_view.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/views/importer_view.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/views/importer_view.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/views/options/general_page_view.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/views/uninstall_view.h View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/views/uninstall_view.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M views/controls/combobox/combobox.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M views/controls/combobox/native_combobox_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/combobox/native_combobox_win.cc View 2 chunks +2 lines, -1 line 0 comments Download
M views/examples/combobox_example.h View 4 chunks +6 lines, -4 lines 0 comments Download
M views/focus/focus_manager_unittest.cc View 4 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
viettrungluu
10 years, 4 months ago (2010-08-22 07:48:08 UTC) #1
brettw
10 years, 4 months ago (2010-08-22 16:36:01 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698