Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4531)

Unified Diff: chrome/browser/dom_ui/plugins_ui.cc

Issue 3152055: Implement about:labs (Closed)
Patch Set: chromeos fix Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/dom_ui/labs_ui.cc ('k') | chrome/browser/labs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/plugins_ui.cc
diff --git a/chrome/browser/dom_ui/plugins_ui.cc b/chrome/browser/dom_ui/plugins_ui.cc
index e529a680c1a6f845da6f9f07344dbb9f200cf095..a52fc88205c4a0b65de937bab904b90cbe24d2f3 100644
--- a/chrome/browser/dom_ui/plugins_ui.cc
+++ b/chrome/browser/dom_ui/plugins_ui.cc
@@ -5,7 +5,6 @@
#include "chrome/browser/dom_ui/plugins_ui.h"
#include <algorithm>
-#include <set>
#include <string>
#include <vector>
@@ -148,20 +147,6 @@ class PluginsDOMHandler : public DOMMessageHandler {
void HandleShowTermsOfServiceMessage(const ListValue* args);
private:
- // Creates a dictionary containing all the information about the given plugin;
- // this is put into the list to "return" for the "requestPluginsData" message.
- DictionaryValue* CreatePluginDetailValue(
- const WebPluginInfo& plugin,
- const std::set<string16>& plugin_blacklist_set);
-
- // Creates a dictionary containing the important parts of the information
- // about the given plugin; this is put into a list and saved in prefs.
- DictionaryValue* CreatePluginSummaryValue(const WebPluginInfo& plugin);
-
- // Update the user preferences to reflect the current (user-selected) state of
- // plugins.
- void UpdatePreferences();
-
DISALLOW_COPY_AND_ASSIGN(PluginsDOMHandler);
};
@@ -175,10 +160,9 @@ void PluginsDOMHandler::RegisterMessages() {
}
void PluginsDOMHandler::HandleRequestPluginsData(const ListValue* args) {
- DictionaryValue* results = new DictionaryValue();
- results->Set("plugins", plugin_updater::GetPluginGroupsData());
-
- dom_ui_->CallJavascriptFunction(L"returnPluginsData", *results);
+ DictionaryValue results;
+ results.Set("plugins", plugin_updater::GetPluginGroupsData());
+ dom_ui_->CallJavascriptFunction(L"returnPluginsData", results);
}
void PluginsDOMHandler::HandleEnablePluginMessage(const ListValue* args) {
« no previous file with comments | « chrome/browser/dom_ui/labs_ui.cc ('k') | chrome/browser/labs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698