Issue 3150039: Merge 57399 - Try to fix top crasher....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3150039: Merge 57399 - Try to fix top crasher.... (Closed)

Created:
10 years, 4 months ago by John Grabowski

Modified:
9 years, 6 months ago

Reviewers:
John Grabowski

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/472/src/

Visibility:
Public.

Description

Merge 57399 - Try to fix top crasher. The problem is timing related so I am unable to write a unit test which proves this fixes things. The essence of the change is to make sure we don't send messages to objects which no longer exist by clearing the delegate pointer in objects we own before we go away (where "we" is an object). The delegate pattern does not get retained, which gives certain objects to hold dangling pointers. BUG=53205 http://crbug.com/53205 Review URL: http://codereview.chromium.org/3158031 TBR=jrg@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57427

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -3 lines)			Patch
M	chrome/browser/cocoa/bookmark_bar_controller.mm	View	3 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/bookmark_bar_folder_controller.mm	View	4 chunks	+13 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/bookmark_button_cell.mm	View	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages