Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4820)

Unified Diff: chrome/browser/cocoa/bookmark_button_cell.mm

Issue 3150039: Merge 57399 - Try to fix top crasher.... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/472/src/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/bookmark_bar_folder_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/bookmark_button_cell.mm
===================================================================
--- chrome/browser/cocoa/bookmark_button_cell.mm (revision 57426)
+++ chrome/browser/cocoa/bookmark_button_cell.mm (working copy)
@@ -180,6 +180,8 @@
// To implement "hover open a bookmark button to open the folder"
// which feels like menus, we override NSButtonCell's mouseEntered:
// and mouseExited:, then and pass them along to our owning control.
+// Note: as verified in a debugger, mouseEntered: does NOT increase
+// the retainCount of the cell or its owning control.
- (void)mouseEntered:(NSEvent*)event {
[super mouseEntered:event];
[[self controlView] mouseEntered:event];
@@ -187,8 +189,8 @@
// See comment above mouseEntered:, above.
- (void)mouseExited:(NSEvent*)event {
+ [[self controlView] mouseExited:event];
[super mouseExited:event];
- [[self controlView] mouseExited:event];
}
- (void)setDrawFolderArrow:(BOOL)draw {
« no previous file with comments | « chrome/browser/cocoa/bookmark_bar_folder_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698