Issue 3142030: Remove wstrings from bookmarks, part 6.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3142030: Remove wstrings from bookmarks, part 6. (Closed)

Created:
10 years, 4 months ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews, ncarter (slow), Raghu Simha, ben+cc_chromium.org, John Grabowski, idana, pam+watch_chromium.org, Paweł Hajdan Jr., tim (not reviewing)

Visibility:
Public.

Description

Remove wstrings from bookmarks, part 6. Remove the wstring version of BookmarkModel::SetTitle(). BUG=23581 TEST=builds and passes enough tests Committed r56985.

Patch Set 1 #

Patch Set 2 : fix views and tests #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -21 lines)			Patch
M	chrome/browser/bookmarks/bookmark_index_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_model.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_model.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/cocoa/applescript/bookmark_node_applescript.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/bookmark_bubble_controller.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/bookmark_model_observer_for_cocoa_unittest.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/bookmark_name_folder_controller.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/bookmark_tree_model.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/bookmark_change_processor.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/bookmark_bubble_view.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/test/live_sync/bookmark_model_verifier.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages