chrome/browser/bookmarks/bookmark_model.h - Issue 3142030: Remove wstrings from bookmarks, part 6.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bookmarks/bookmark_model.h

Issue 3142030: Remove wstrings from bookmarks, part 6. (Closed)

Patch Set: fix views and tests Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/bookmarks/bookmark_model.h

diff --git a/chrome/browser/bookmarks/bookmark_model.h b/chrome/browser/bookmarks/bookmark_model.h

index 8fcfb83e34c5dad8b5a643e3c3acd4eb1e8d4475..988ad7de46cd97fefc8f96ea1dbc46cbe4e2b0a4 100644

--- a/chrome/browser/bookmarks/bookmark_model.h

+++ b/chrome/browser/bookmarks/bookmark_model.h

@@ -230,11 +230,7 @@ class BookmarkModel : public NotificationObserver, public BookmarkService {

// loaded it is loaded and the observer of the model notified when done.

const SkBitmap& GetFavIcon(const BookmarkNode* node);

- // TODO(munjal): Remove wstring overload once all code is moved to string16.

// Sets the title of the specified node.

-#if !defined(WCHAR_T_IS_UTF16)

- void SetTitle(const BookmarkNode* node, const std::wstring& title);

-#endif

void SetTitle(const BookmarkNode* node, const string16& title);

// Sets the URL of the specified bookmark node.