Issue 3141042: DevTools: support disabled and checked context menu items.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3141042: DevTools: support disabled and checked context menu items. (Closed)

Created:
10 years, 4 months ago by pfeldman

Modified:
9 years, 7 months ago

Reviewers:
yurys

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, brettw-cc_chromium.org, pam+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

DevTools: support disabled and checked context menu items. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57320

Patch Set 1 #

Patch Set 2 : Extra file removed. #

Patch Set 3 : Added type differetiation. #

Patch Set 4 : With enabled. #

Total comments: 2

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -0 lines)			Patch
	M	chrome/browser/tab_contents/render_view_context_menu.cc	View	1 2 3	3 chunks	+29 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yurys

10 years, 4 months ago (2010-08-25 12:55:29 UTC) #3

lgtm

http://codereview.chromium.org/3141042/diff/5001/6001
File chrome/browser/tab_contents/render_view_context_menu.cc (right):

http://codereview.chromium.org/3141042/diff/5001/6001#newcode763
chrome/browser/tab_contents/render_view_context_menu.cc:763: }
There should be ASSERT_NOT_REACHED();

http://codereview.chromium.org/3141042/diff/5001/6001#newcode999
chrome/browser/tab_contents/render_view_context_menu.cc:999: return false;
ditto.

Expand Messages | Collapse Messages