DevTools: support disabled and checked context menu items.

chrome/browser/tab_contents/render_view_context_menu.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <set>
 
 #include "chrome/browser/tab_contents/render_view_context_menu.h"
 
 #include "app/l10n_util.h"
@@ skipping 394 matching lines @@
   NOTREACHED();
 }
 
 bool RenderViewContextMenu::AppendCustomItems() {
   std::vector<WebMenuItem>& custom_items = params_.custom_items;
   for (size_t i = 0; i < custom_items.size(); ++i) {
     DCHECK(IDC_CONTENT_CONTEXT_CUSTOM_FIRST + custom_items[i].action <
         IDC_CONTENT_CONTEXT_CUSTOM_LAST);
     if (custom_items[i].type == WebMenuItem::SEPARATOR) {
       menu_model_.AddSeparator();
+    } else if (custom_items[i].type == WebMenuItem::CHECKABLE_OPTION) {
+      menu_model_.AddCheckItem(
+          custom_items[i].action + IDC_CONTENT_CONTEXT_CUSTOM_FIRST,
+          custom_items[i].label);
     } else {
       menu_model_.AddItem(
           custom_items[i].action + IDC_CONTENT_CONTEXT_CUSTOM_FIRST,
           custom_items[i].label);
     }
   }
   return custom_items.size() > 0;
 }
 
 void RenderViewContextMenu::AppendDeveloperItems() {
@@ skipping 316 matching lines @@
       (id < IDC_CONTENT_CONTEXT_CUSTOM_LAST)) {
     unsigned action = id - IDC_CONTENT_CONTEXT_CUSTOM_FIRST;
     for (size_t i = 0; i < params_.custom_items.size(); ++i) {
       if (params_.custom_items[i].action == action)
         return params_.custom_items[i].enabled;
     }
     NOTREACHED();
     return false;
   }
 
+  // Custom WebKit items.
+  if (id >= IDC_CONTENT_CONTEXT_CUSTOM_FIRST &&
+      id <= IDC_CONTENT_CONTEXT_CUSTOM_LAST) {
+    const std::vector<WebMenuItem>& custom_items = params_.custom_items;
+    for (size_t i = 0; i < custom_items.size(); ++i) {
+      int action_id = IDC_CONTENT_CONTEXT_CUSTOM_FIRST + custom_items[i].action;
+      if (action_id == id)
+        return custom_items[i].enabled;
+    }

[yurys, 2010/08/25 12:55:29]

There should be ASSERT_NOT_REACHED();

+    return true;
+  }
+
   // Extension items.
   if (id >= IDC_EXTENSIONS_CONTEXT_CUSTOM_FIRST &&
       id <= IDC_EXTENSIONS_CONTEXT_CUSTOM_LAST) {
     // In the future we may add APIs for extensions to disable items, but for
     // now all items are implicitly enabled.
     return true;
   }
 
   switch (id) {
     case IDC_BACK:
@@ skipping 203 matching lines @@
   if (id == IDC_CONTENT_CONTEXT_LOOP) {
     return (params_.media_flags &
             WebContextMenuData::MediaLoop) != 0;
   }
 
   if (id == IDC_CONTENT_CONTEXT_CONTROLS) {
     return (params_.media_flags &
             WebContextMenuData::MediaControls) != 0;
   }
 
+  // Custom WebKit items.
+  if (id >= IDC_CONTENT_CONTEXT_CUSTOM_FIRST &&
+      id <= IDC_CONTENT_CONTEXT_CUSTOM_LAST) {
+    const std::vector<WebMenuItem>& custom_items = params_.custom_items;
+    for (size_t i = 0; i < custom_items.size(); ++i) {
+      int action_id = IDC_CONTENT_CONTEXT_CUSTOM_FIRST + custom_items[i].action;
+      if (action_id == id)
+        return custom_items[i].checked;
+    }
+    return false;

[yurys, 2010/08/25 12:55:29]

ditto.

+  }
+
+  // Extension items.
   if (id >= IDC_EXTENSIONS_CONTEXT_CUSTOM_FIRST &&
       id <= IDC_EXTENSIONS_CONTEXT_CUSTOM_LAST) {
     ExtensionMenuItem* item = GetExtensionMenuItem(id);
     if (item)
       return item->checked();
     else
       return false;
   }
 
 #if defined(OS_MACOSX)
@@ skipping 442 matching lines @@
       UTF8ToWide(profile_->GetPrefs()->GetString(prefs::kAcceptLanguages)),
       g_browser_process->clipboard());
 }
 
 void RenderViewContextMenu::MediaPlayerActionAt(
     const gfx::Point& location,
     const WebMediaPlayerAction& action) {
   source_tab_contents_->render_view_host()->MediaPlayerActionAt(
       location, action);
 }