Issue 3135035: Fix broken thumbnails for sites with redirects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3135035: Fix broken thumbnails for sites with redirects. (Closed)

Created:
10 years, 4 months ago by Nik Shkrob

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

Fix broken thumbnails for sites with redirects. BUG=52621 TEST=unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57113

Patch Set 1 #

Patch Set 2 : Fix unit tests. #

Patch Set 3 : Synced #

Patch Set 4 : Really synced. #

Patch Set 5 : Undo unnecessary changes. #

Patch Set 6 : Don't replace canonical URLs; Allow blacklisting of one of the duplicates. #

Patch Set 7 : Adding GetPageThumbnail test. #

Total comments: 1

Patch Set 8 : Comment. #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -18 lines)			Patch
M	chrome/browser/dom_ui/most_visited_handler.cc	View	1 2	1 chunk	+0 lines, -11 lines	0 comments	Download
M	chrome/browser/history/top_sites.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/history/top_sites.cc	View	1 2 3 4 5 6 7	6 chunks	+12 lines, -7 lines	0 comments	Download
M	chrome/browser/history/top_sites_unittest.cc	View	1 2 3 4	1 chunk	+44 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nik Shkrob

The main problem was much simpler - GetPageThumbnail wasn't using canonical URLs.

10 years, 4 months ago (2010-08-20 19:00:16 UTC) #1

brettw

Is it possible to write a simple unit test for this operation?

10 years, 4 months ago (2010-08-20 19:44:42 UTC) #2

Nik Shkrob

On 2010/08/20 19:44:42, brettw wrote: > Is it possible to write a simple unit test ...

10 years, 4 months ago (2010-08-20 22:08:15 UTC) #3

brettw

10 years, 4 months ago (2010-08-20 22:17:46 UTC) #4

LGTM

http://codereview.chromium.org/3135035/diff/20001/21002
File chrome/browser/history/top_sites.cc (right):

http://codereview.chromium.org/3135035/diff/20001/21002#newcode383
chrome/browser/history/top_sites.cc:383: return MD5String(url.spec());
Can you add a comment here about why we don't want to call GetCanonicalURL?

Expand Messages | Collapse Messages