Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1162)

Unified Diff: chrome/browser/dom_ui/most_visited_handler.cc

Issue 3135035: Fix broken thumbnails for sites with redirects. (Closed)
Patch Set: Comment. Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/history/top_sites.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/most_visited_handler.cc
diff --git a/chrome/browser/dom_ui/most_visited_handler.cc b/chrome/browser/dom_ui/most_visited_handler.cc
index 9a045d8bc956b02d4a8298364138ed5efe6e81ea..66097f0ab5eb9ec8e1cdff289cbf78516447939f 100644
--- a/chrome/browser/dom_ui/most_visited_handler.cc
+++ b/chrome/browser/dom_ui/most_visited_handler.cc
@@ -127,17 +127,6 @@ void MostVisitedHandler::HandleGetMostVisited(const ListValue* args) {
}
}
-// Set a DictionaryValue |dict| from a MostVisitedURL.
-void SetDictionaryValue(const history::MostVisitedURL& url,
- DictionaryValue& dict) {
- NewTabUI::SetURLTitleAndDirection(&dict, url.title, url.url);
- dict.SetString("url", url.url.spec());
- dict.SetString("faviconUrl", url.favicon_url.spec());
- // TODO(Nik): Need thumbnailUrl?
- // TODO(Nik): Add pinned and blacklisted URLs.
- dict.SetBoolean("pinned", false);
-}
-
void MostVisitedHandler::SendPagesValue() {
if (pages_value_.get()) {
FundamentalValue first_run(IsFirstRun());
« no previous file with comments | « no previous file | chrome/browser/history/top_sites.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698