Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: chrome/browser/browser_init_browsertest.cc

Issue 3134008: CommandLine: eliminate wstring-accepting AppendLooseValue (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: utf8 Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browser_init_browsertest.cc
diff --git a/chrome/browser/browser_init_browsertest.cc b/chrome/browser/browser_init_browsertest.cc
index b6ad56353357e7bd834655e2a901f3232aa3ae46..b9f8514e09ccb210902ecc30b32714e8a2618659 100644
--- a/chrome/browser/browser_init_browsertest.cc
+++ b/chrome/browser/browser_init_browsertest.cc
@@ -66,13 +66,13 @@ IN_PROC_BROWSER_TEST_F(BrowserInitTest, FLAKY_OpenURLsPopup) {
// to start on most BuildBot runs and I don't want to add longer delays to
// the test. I'll circle back and make this work properly when i get a chance.
IN_PROC_BROWSER_TEST_F(BrowserInitTest, FLAKY_BlockBadURLs) {
- const std::wstring testurlstr(L"http://localhost/");
- const GURL testurl(WideToUTF16Hack(testurlstr));
+ const char* testurlstr = "http://localhost/";
+ const GURL testurl(testurlstr);
CommandLine cmdline(CommandLine::ARGUMENTS_ONLY);
- cmdline.AppendLooseValue(testurlstr);
- cmdline.AppendLooseValue(std::wstring(L"javascript:alert('boo')"));
- cmdline.AppendLooseValue(testurlstr);
- cmdline.AppendLooseValue(std::wstring(L"view-source:http://localhost/"));
+ cmdline.AppendArg(testurlstr);
+ cmdline.AppendArg("javascript:alert('boo')");
+ cmdline.AppendArg(testurlstr);
+ cmdline.AppendArg("view-source:http://localhost/");
// This will pick up the current browser instance.
BrowserInit::LaunchWithProfile launch(FilePath(), cmdline);

Powered by Google App Engine
This is Rietveld 408576698