chrome/app/chrome_main_uitest.cc - Issue 3134008: CommandLine: eliminate wstring-accepting AppendLooseValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/chrome_main_uitest.cc

Issue 3134008: CommandLine: eliminate wstring-accepting AppendLooseValue (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: utf8 Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/app/chrome_main_uitest.cc

diff --git a/chrome/app/chrome_main_uitest.cc b/chrome/app/chrome_main_uitest.cc

index 8d13b895dda09e4e9ef2ba796ff63af8e3d66bca..851a592bc6b527f21ab702a17bc9fc81d900bee0 100644

--- a/chrome/app/chrome_main_uitest.cc

+++ b/chrome/app/chrome_main_uitest.cc

@@ -64,7 +64,7 @@ TEST_F(ChromeMainTest, ReuseBrowserInstanceWhenOpeningFile) {

FilePath test_file = test_data_directory_.AppendASCII("empty.html");

CommandLine command_line(CommandLine::ARGUMENTS_ONLY);

- command_line.AppendLooseValue(test_file.ToWStringHack());

+ command_line.AppendArgPath(test_file);

ASSERT_TRUE(LaunchAnotherBrowserBlockUntilClosed(command_line));

ASSERT_TRUE(automation()->IsURLDisplayed(net::FilePathToFileURL(test_file)));