Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 3132023: Add language_prefs namespace to language_preferences.h. (Closed)

Created:
10 years, 4 months ago by satorux1
Modified:
9 years, 6 months ago
Reviewers:
Yusuke Sato
CC:
chromium-reviews, Paweł Hajdan Jr., nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Add language_prefs namespace to language_preferences.h. language_preferences.h exports lots of constants hence polutes chromeos namespace. TEST=compiles. try bots. BUG=chromium-os:5848 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56803

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+379 lines, -284 lines) Patch
M chrome/browser/chromeos/cros/input_method_library.cc View 1 5 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/dom_ui/language_chewing_options_handler.cc View 3 chunks +15 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/dom_ui/language_hangul_options_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/dom_ui/language_mozc_options_handler.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/dom_ui/language_options_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/dom_ui/language_pinyin_options_handler.cc View 1 chunk +11 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/dom_ui/system_options_handler.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/language_preferences.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/language_preferences.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/language_preferences_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/language_switch_menu.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker.cc View 1 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/language_chewing_config_view.h View 1 chunk +9 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/options/language_chewing_config_view.cc View 6 chunks +35 lines, -26 lines 0 comments Download
M chrome/browser/chromeos/options/language_config_util.h View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/options/language_hangul_config_view.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/options/language_mozc_config_view.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/options/language_mozc_config_view.cc View 10 chunks +39 lines, -32 lines 0 comments Download
M chrome/browser/chromeos/options/language_pinyin_config_view.h View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/options/language_pinyin_config_view.cc View 5 chunks +14 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/options/system_page_view.cc View 7 chunks +26 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/preferences.h View 1 chunk +14 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 5 chunks +142 lines, -111 lines 0 comments Download
M chrome/browser/chromeos/status/language_menu_button.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
satorux1
10 years, 4 months ago (2010-08-19 09:01:20 UTC) #1
Yusuke Sato
LGTM might be better to rerun linux_chromeos trybot tho. http://codereview.chromium.org/3132023/diff/1/2 File chrome/browser/chromeos/cros/input_method_library.cc (right): http://codereview.chromium.org/3132023/diff/1/2#newcode178 chrome/browser/chromeos/cros/input_method_library.cc:178: ...
10 years, 4 months ago (2010-08-19 22:23:55 UTC) #2
satorux1
10 years, 4 months ago (2010-08-20 00:52:57 UTC) #3
http://codereview.chromium.org/3132023/diff/1/2
File chrome/browser/chromeos/cros/input_method_library.cc (right):

http://codereview.chromium.org/3132023/diff/1/2#newcode178
chrome/browser/chromeos/cros/input_method_library.cc:178:
value.string_list_value[0] == language_prefs::kHardwareKeyboardLayout) {
On 2010/08/19 22:23:55, Yusuke Sato wrote:
> 80 chars

Done.

Powered by Google App Engine
This is Rietveld 408576698