Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Side by Side Diff: chrome/browser/chromeos/dom_ui/language_pinyin_options_handler.cc

Issue 3132023: Add language_prefs namespace to language_preferences.h. (Closed)
Patch Set: address comments Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/dom_ui/language_pinyin_options_handler.h" 5 #include "chrome/browser/chromeos/dom_ui/language_pinyin_options_handler.h"
6 6
7 #include "app/l10n_util.h" 7 #include "app/l10n_util.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "chrome/browser/chromeos/dom_ui/language_options_util.h" 9 #include "chrome/browser/chromeos/dom_ui/language_options_util.h"
10 #include "chrome/browser/chromeos/language_preferences.h" 10 #include "chrome/browser/chromeos/language_preferences.h"
11 #include "grit/generated_resources.h" 11 #include "grit/generated_resources.h"
12 12
13 // TODO(kochi): Add prefix for each language (e.g. "Pinyin") for each i18n 13 // TODO(kochi): Add prefix for each language (e.g. "Pinyin") for each i18n
14 // identifier. 14 // identifier.
15 15
16 namespace chromeos { 16 namespace chromeos {
17 17
18 LanguagePinyinOptionsHandler::LanguagePinyinOptionsHandler() { 18 LanguagePinyinOptionsHandler::LanguagePinyinOptionsHandler() {
19 } 19 }
20 20
21 LanguagePinyinOptionsHandler::~LanguagePinyinOptionsHandler() { 21 LanguagePinyinOptionsHandler::~LanguagePinyinOptionsHandler() {
22 } 22 }
23 23
24 void LanguagePinyinOptionsHandler::GetLocalizedValues( 24 void LanguagePinyinOptionsHandler::GetLocalizedValues(
25 DictionaryValue* localized_strings) { 25 DictionaryValue* localized_strings) {
26 DCHECK(localized_strings); 26 DCHECK(localized_strings);
27 // Language Pinyin page - ChromeOS 27 // Language Pinyin page - ChromeOS
28 for (size_t i = 0; i < kNumPinyinBooleanPrefs; ++i) { 28 for (size_t i = 0; i < language_prefs::kNumPinyinBooleanPrefs; ++i) {
29 localized_strings->SetString( 29 localized_strings->SetString(
30 GetI18nContentValue(kPinyinBooleanPrefs[i]), 30 GetI18nContentValue(language_prefs::kPinyinBooleanPrefs[i]),
31 l10n_util::GetStringUTF16(kPinyinBooleanPrefs[i].message_id)); 31 l10n_util::GetStringUTF16(
32 language_prefs::kPinyinBooleanPrefs[i].message_id));
32 } 33 }
33 34
34 localized_strings->SetString( 35 localized_strings->SetString(
35 GetI18nContentValue(kPinyinDoublePinyinSchema), 36 GetI18nContentValue(language_prefs::kPinyinDoublePinyinSchema),
36 l10n_util::GetStringUTF16( 37 l10n_util::GetStringUTF16(
37 kPinyinDoublePinyinSchema.label_message_id)); 38 language_prefs::kPinyinDoublePinyinSchema.label_message_id));
38 ListValue* list_value = new ListValue(); 39 ListValue* list_value = new ListValue();
39 for (size_t i = 0; 40 for (size_t i = 0;
40 i < LanguageMultipleChoicePreference<int>::kMaxItems; 41 i < language_prefs::LanguageMultipleChoicePreference<int>::kMaxItems;
41 ++i) { 42 ++i) {
42 if (kPinyinDoublePinyinSchema.values_and_ids[i]. 43 if (language_prefs::kPinyinDoublePinyinSchema.values_and_ids[i].
43 item_message_id == 0) 44 item_message_id == 0)
44 break; 45 break;
45 ListValue* option = new ListValue(); 46 ListValue* option = new ListValue();
46 option->Append(Value::CreateIntegerValue( 47 option->Append(Value::CreateIntegerValue(
47 kPinyinDoublePinyinSchema.values_and_ids[i]. 48 language_prefs::kPinyinDoublePinyinSchema.values_and_ids[i].
48 ibus_config_value)); 49 ibus_config_value));
49 option->Append(Value::CreateStringValue(l10n_util::GetStringUTF16( 50 option->Append(Value::CreateStringValue(l10n_util::GetStringUTF16(
50 kPinyinDoublePinyinSchema.values_and_ids[i]. 51 language_prefs::kPinyinDoublePinyinSchema.values_and_ids[i].
51 item_message_id))); 52 item_message_id)));
52 list_value->Append(option); 53 list_value->Append(option);
53 } 54 }
54 localized_strings->Set( 55 localized_strings->Set(
55 GetTemplateDataPropertyName(kPinyinDoublePinyinSchema), 56 GetTemplateDataPropertyName(language_prefs::kPinyinDoublePinyinSchema),
56 list_value); 57 list_value);
57 } 58 }
58 59
59 } // namespace chromeos 60 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/dom_ui/language_options_util.h ('k') | chrome/browser/chromeos/dom_ui/system_options_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698