Issue 3126020: Remove code duplication and improve style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3126020: Remove code duplication and improve style. (Closed)

Created:
10 years, 4 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews

Visibility:
Public.

Description

Remove code duplication and improve style. Create a Popen function to reduce code duplication. Use RemoveDirectory where relevant. Make drover slightly more posix friendly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56893

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -105 lines)			Patch
M	drover.py	View	7 chunks	+19 lines, -53 lines	0 comments	Download
M	gcl.py	View	1 chunk	+2 lines, -8 lines	0 comments	Download
M	gclient_scm.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gclient_utils.py	View	6 chunks	+20 lines, -21 lines	0 comments	Download
M	scm.py	View	2 chunks	+3 lines, -11 lines	0 comments	Download
M	tests/gclient_utils_test.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/scm_unittest.py	View	3 chunks	+9 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages