tests/gclient_utils_test.py - Issue 3126020: Remove code duplication and improve style. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(400)

My Issues | Starred Open | Closed | All

Unified Diff: tests/gclient_utils_test.py

Issue 3126020: Remove code duplication and improve style. (Closed)

Patch Set: Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « scm.py ('k') | tests/scm_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/gclient_utils_test.py

diff --git a/tests/gclient_utils_test.py b/tests/gclient_utils_test.py

index 01b22210714b9e689827c6d07b63ff891637b919..06388780b576465e7d7013f3ed3e04e301dc1931 100755

--- a/tests/gclient_utils_test.py

+++ b/tests/gclient_utils_test.py

@@ -24,7 +24,7 @@ class GclientUtilsUnittest(GclientUtilBase):

'CheckCall', 'CheckCallError', 'Error', 'ExecutionQueue', 'FileRead',

'FileWrite', 'FindFileUpwards', 'FindGclientRoot',

'GetGClientRootAndEntries', 'GetNamedNodeText',

- 'GetNodeNamedAttributeText', 'PathDifference', 'ParseXML',

+ 'GetNodeNamedAttributeText', 'PathDifference', 'ParseXML', 'Popen',

'PrintableObject', 'RemoveDirectory', 'SplitUrlRevision',

'SubprocessCall', 'SubprocessCallAndFilter', 'SyntaxErrorToError',

'WorkItem',

« no previous file with comments | « scm.py ('k') | tests/scm_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698