Issue 3122033: Adds support for EXT_framebuffer_multisample...

Issue 3122033: Adds support for EXT_framebuffer_multisample... (Closed)

Created:
10 years, 4 months ago by gman1

Modified:
9 years, 7 months ago

Reviewers:
apatrick, apatrick_chromium

CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Adds support for EXT_framebuffer_multisample I probably need more tests but in order to test I need to figure out how to init the system with different caps enabled from the unit tests and that's probably not a small amount of work so leaving that till later. TEST=some unit tests, ran conformance tests BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57081

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+665 lines, -62 lines)			Patch
M	gpu/GLES2/gl2ext.h	View		2 chunks	+72 lines, -3 lines	1 comment	Download
M	gpu/command_buffer/build_gles2_cmd_buffer.py	View	1	5 chunks	+25 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_c_lib_autogen.h	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_cmd_helper_autogen.h	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_implementation_autogen.h	View		1 chunk	+29 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_format_autogen.h	View		1 chunk	+135 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_format_test_autogen.h	View		1 chunk	+52 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_id_test_autogen.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_ids_autogen.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/context_group.h	View		3 chunks	+15 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/context_group.cc	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/context_group_unittest.cc	View		2 chunks	+19 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View		25 chunks	+192 lines, -49 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_autogen.h	View		1 chunk	+62 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h	View		6 chunks	+8 lines, -6 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_validation_autogen.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

apatrick

10 years, 4 months ago (2010-08-23 18:03:43 UTC) #2

LGTM

http://codereview.chromium.org/3122033/diff/19001/13002
File gpu/GLES2/gl2ext.h (right):

http://codereview.chromium.org/3122033/diff/19001/13002#newcode801
gpu/GLES2/gl2ext.h:801: /* GL_EXT_framebuffer_mutlisample */
mutlisample -> multisample

Expand Messages | Collapse Messages