Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: chrome/browser/dom_ui/browser_options_handler.cc

Issue 3119038: yRevert 57093 - dom-ui options: record user metrics for pref changes.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/dom_ui/advanced_options_handler.cc ('k') | chrome/browser/dom_ui/core_options_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/browser_options_handler.cc
===================================================================
--- chrome/browser/dom_ui/browser_options_handler.cc (revision 57095)
+++ chrome/browser/dom_ui/browser_options_handler.cc (working copy)
@@ -15,7 +15,6 @@
#include "chrome/browser/custom_home_pages_table_model.h"
#include "chrome/browser/dom_ui/dom_ui_favicon_source.h"
#include "chrome/browser/dom_ui/options_managed_banner_handler.h"
-#include "chrome/browser/metrics/user_metrics.h"
#include "chrome/browser/net/url_fixer_upper.h"
#include "chrome/browser/profile.h"
#include "chrome/browser/options_window.h"
@@ -140,8 +139,6 @@
}
void BrowserOptionsHandler::BecomeDefaultBrowser(const ListValue* args) {
- UserMetricsRecordAction(UserMetricsAction("Options_SetAsDefaultBrowser"),
- NULL);
#if defined(OS_MACOSX)
if (ShellIntegration::SetAsDefaultBrowser())
UpdateDefaultBrowserState();
@@ -229,9 +226,6 @@
if (selected_index >= 0 &&
selected_index < static_cast<int>(model_urls.size()))
template_url_model_->SetDefaultSearchProvider(model_urls[selected_index]);
-
- UserMetricsRecordAction(UserMetricsAction("Options_SearchEngineChanged"),
- NULL);
}
void BrowserOptionsHandler::UpdateSearchEngines() {
« no previous file with comments | « chrome/browser/dom_ui/advanced_options_handler.cc ('k') | chrome/browser/dom_ui/core_options_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698