Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: chrome/browser/dom_ui/browser_options_handler.cc

Issue 3119038: yRevert 57093 - dom-ui options: record user metrics for pref changes.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/dom_ui/browser_options_handler.h" 5 #include "chrome/browser/dom_ui/browser_options_handler.h"
6 6
7 #include "app/l10n_util.h" 7 #include "app/l10n_util.h"
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/scoped_ptr.h" 9 #include "base/scoped_ptr.h"
10 #include "base/singleton.h" 10 #include "base/singleton.h"
11 #include "base/string_number_conversions.h" 11 #include "base/string_number_conversions.h"
12 #include "base/utf_string_conversions.h" 12 #include "base/utf_string_conversions.h"
13 #include "base/values.h" 13 #include "base/values.h"
14 #include "chrome/browser/chrome_thread.h" 14 #include "chrome/browser/chrome_thread.h"
15 #include "chrome/browser/custom_home_pages_table_model.h" 15 #include "chrome/browser/custom_home_pages_table_model.h"
16 #include "chrome/browser/dom_ui/dom_ui_favicon_source.h" 16 #include "chrome/browser/dom_ui/dom_ui_favicon_source.h"
17 #include "chrome/browser/dom_ui/options_managed_banner_handler.h" 17 #include "chrome/browser/dom_ui/options_managed_banner_handler.h"
18 #include "chrome/browser/metrics/user_metrics.h"
19 #include "chrome/browser/net/url_fixer_upper.h" 18 #include "chrome/browser/net/url_fixer_upper.h"
20 #include "chrome/browser/profile.h" 19 #include "chrome/browser/profile.h"
21 #include "chrome/browser/options_window.h" 20 #include "chrome/browser/options_window.h"
22 #include "chrome/browser/session_startup_pref.h" 21 #include "chrome/browser/session_startup_pref.h"
23 #include "chrome/installer/util/browser_distribution.h" 22 #include "chrome/installer/util/browser_distribution.h"
24 #include "grit/chromium_strings.h" 23 #include "grit/chromium_strings.h"
25 #include "grit/generated_resources.h" 24 #include "grit/generated_resources.h"
26 25
27 BrowserOptionsHandler::BrowserOptionsHandler() 26 BrowserOptionsHandler::BrowserOptionsHandler()
28 : template_url_model_(NULL), startup_custom_pages_table_model_(NULL) { 27 : template_url_model_(NULL), startup_custom_pages_table_model_(NULL) {
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 else 132 else
134 status_string_id = IDS_OPTIONS_DEFAULTBROWSER_UNKNOWN; 133 status_string_id = IDS_OPTIONS_DEFAULTBROWSER_UNKNOWN;
135 134
136 SetDefaultBrowserUIString(status_string_id); 135 SetDefaultBrowserUIString(status_string_id);
137 #else 136 #else
138 default_browser_worker_->StartCheckDefaultBrowser(); 137 default_browser_worker_->StartCheckDefaultBrowser();
139 #endif 138 #endif
140 } 139 }
141 140
142 void BrowserOptionsHandler::BecomeDefaultBrowser(const ListValue* args) { 141 void BrowserOptionsHandler::BecomeDefaultBrowser(const ListValue* args) {
143 UserMetricsRecordAction(UserMetricsAction("Options_SetAsDefaultBrowser"),
144 NULL);
145 #if defined(OS_MACOSX) 142 #if defined(OS_MACOSX)
146 if (ShellIntegration::SetAsDefaultBrowser()) 143 if (ShellIntegration::SetAsDefaultBrowser())
147 UpdateDefaultBrowserState(); 144 UpdateDefaultBrowserState();
148 #else 145 #else
149 default_browser_worker_->StartSetAsDefaultBrowser(); 146 default_browser_worker_->StartSetAsDefaultBrowser();
150 // Callback takes care of updating UI. 147 // Callback takes care of updating UI.
151 #endif 148 #endif
152 } 149 }
153 150
154 int BrowserOptionsHandler::StatusStringIdForState( 151 int BrowserOptionsHandler::StatusStringIdForState(
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 if (!ExtractIntegerValue(args, &selected_index)) { 219 if (!ExtractIntegerValue(args, &selected_index)) {
223 NOTREACHED(); 220 NOTREACHED();
224 return; 221 return;
225 } 222 }
226 223
227 std::vector<const TemplateURL*> model_urls = 224 std::vector<const TemplateURL*> model_urls =
228 template_url_model_->GetTemplateURLs(); 225 template_url_model_->GetTemplateURLs();
229 if (selected_index >= 0 && 226 if (selected_index >= 0 &&
230 selected_index < static_cast<int>(model_urls.size())) 227 selected_index < static_cast<int>(model_urls.size()))
231 template_url_model_->SetDefaultSearchProvider(model_urls[selected_index]); 228 template_url_model_->SetDefaultSearchProvider(model_urls[selected_index]);
232
233 UserMetricsRecordAction(UserMetricsAction("Options_SearchEngineChanged"),
234 NULL);
235 } 229 }
236 230
237 void BrowserOptionsHandler::UpdateSearchEngines() { 231 void BrowserOptionsHandler::UpdateSearchEngines() {
238 template_url_model_ = dom_ui_->GetProfile()->GetTemplateURLModel(); 232 template_url_model_ = dom_ui_->GetProfile()->GetTemplateURLModel();
239 if (template_url_model_) { 233 if (template_url_model_) {
240 template_url_model_->Load(); 234 template_url_model_->Load();
241 template_url_model_->AddObserver(this); 235 template_url_model_->AddObserver(this);
242 OnTemplateURLModelChanged(); 236 OnTemplateURLModelChanged();
243 } 237 }
244 } 238 }
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
334 } 328 }
335 329
336 void BrowserOptionsHandler::SaveStartupPagesPref() { 330 void BrowserOptionsHandler::SaveStartupPagesPref() {
337 PrefService* prefs = dom_ui_->GetProfile()->GetPrefs(); 331 PrefService* prefs = dom_ui_->GetProfile()->GetPrefs();
338 332
339 SessionStartupPref pref = SessionStartupPref::GetStartupPref(prefs); 333 SessionStartupPref pref = SessionStartupPref::GetStartupPref(prefs);
340 pref.urls = startup_custom_pages_table_model_->GetURLs(); 334 pref.urls = startup_custom_pages_table_model_->GetURLs();
341 335
342 SessionStartupPref::SetStartupPref(prefs, pref); 336 SessionStartupPref::SetStartupPref(prefs, pref);
343 } 337 }
OLDNEW
« no previous file with comments | « chrome/browser/dom_ui/advanced_options_handler.cc ('k') | chrome/browser/dom_ui/core_options_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698