Issue 3119038: yRevert 57093 - dom-ui options: record user metrics for pref changes....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3119038: yRevert 57093 - dom-ui options: record user metrics for pref changes.... (Closed)

Created:
10 years, 4 months ago by csilv

Modified:
9 years, 7 months ago

Reviewers:
csilv

CC:
chromium-reviews, dhg, arv (Not doing code reviews), davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

yRevert 57093 - dom-ui options: record user metrics for pref changes. BUG=52520 TEST=Verify metrics are saved when changing options in dom-ui options window (--enable-tabbed-options). Review URL: http://codereview.chromium.org/3190004 TBR=csilv@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57096

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -206 lines)			Patch
M	chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.cc	View	3 chunks	+2 lines, -7 lines	0 comments	Download
M	chrome/browser/dom_ui/advanced_options_handler.cc	View	2 chunks	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/dom_ui/browser_options_handler.cc	View	3 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/dom_ui/core_options_handler.h	View	2 chunks	+1 line, -11 lines	0 comments	Download
M	chrome/browser/dom_ui/core_options_handler.cc	View	7 chunks	+7 lines, -35 lines	0 comments	Download
M	chrome/browser/resources/options/advanced_options.html	View	5 chunks	+19 lines, -24 lines	0 comments	Download
M	chrome/browser/resources/options/advanced_options.js	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/options/autofill_options.html	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/resources/options/browser_options.html	View	2 chunks	+12 lines, -18 lines	0 comments	Download
M	chrome/browser/resources/options/browser_options.js	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/options/content_settings.js	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/options/font_settings_overlay.html	View	4 chunks	+7 lines, -14 lines	0 comments	Download
M	chrome/browser/resources/options/personal_options.html	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/options/personal_options.js	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/resources/options/pref_ui.js	View	10 chunks	+8 lines, -37 lines	0 comments	Download
M	chrome/browser/resources/options/preferences.js	View	4 chunks	+8 lines, -20 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages