Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 3117039: Refactor SubprocessCallAndFilter() to remove positional arguments. (Closed)

Created:
10 years, 4 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Refactor SubprocessCallAndFilter() to remove positional arguments. This way the function is much more similar to subprocess.call(). Further changes will be done, to be able to convert all the function, to be able to parallelize output without corrupting it. Used pylint to verify call graph correctness, causing some other unrelated changes. TEST=unit tests BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -173 lines) Patch
M gcl.py View 3 chunks +4 lines, -7 lines 0 comments Download
M gclient.py View 3 chunks +4 lines, -4 lines 0 comments Download
M gclient_scm.py View 9 chunks +13 lines, -16 lines 0 comments Download
M gclient_utils.py View 3 chunks +31 lines, -32 lines 0 comments Download
M scm.py View 6 chunks +15 lines, -87 lines 0 comments Download
M tests/gclient_scm_test.py View 8 chunks +14 lines, -6 lines 0 comments Download
M tests/gclient_utils_test.py View 5 chunks +17 lines, -16 lines 0 comments Download
M tests/scm_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M trychange.py View 4 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
10 years, 4 months ago (2010-08-24 23:58:42 UTC) #1
bradn
10 years, 4 months ago (2010-08-25 19:53:23 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698