Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: trychange.py

Issue 3117039: Refactor SubprocessCallAndFilter() to remove positional arguments. (Closed)
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/scm_unittest.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trychange.py
diff --git a/trychange.py b/trychange.py
index b1609551708e7cde2eb540ca250f550774c57c99..bed851ea0e2025087edcf7ddcc448675158eaeb0 100755
--- a/trychange.py
+++ b/trychange.py
@@ -97,6 +97,7 @@ class SCM(object):
self.options.files = None
self.codereview_settings = None
self.codereview_settings_file = 'codereview.settings'
+ self.gclient_root = None
def GetFileNames(self):
"""Return the list of files in the diff."""
@@ -136,7 +137,6 @@ class SCM(object):
def _GclientStyleSettings(self):
"""Find the root, assuming a gclient-style checkout."""
- self.gclient_root = None
if not self.options.no_gclient and not self.options.root:
root = self.checkout_root
self.gclient_root = gclient_utils.FindGclientRoot(root)
@@ -301,7 +301,7 @@ def _SendChangeHTTP(options):
'server port to connect to.')
values = _ParseSendChangeOptions(options)
- description = ''.join("%s=%s\n" % (k,v) for (k,v) in values.iteritems())
+ description = ''.join("%s=%s\n" % (k, v) for (k, v) in values.iteritems())
values['patch'] = options.diff
url = 'http://%s:%s/send_try_patch' % (options.host, options.port)
@@ -345,7 +345,7 @@ def _SendChangeSVN(options):
' try server svn repository to connect to.')
values = _ParseSendChangeOptions(options)
- description = ''.join("%s=%s\n" % (k,v) for (k,v) in values.iteritems())
+ description = ''.join("%s=%s\n" % (k, v) for (k, v) in values.iteritems())
logging.info('Sending by SVN')
logging.info(description)
logging.info(options.svn_repo)
« no previous file with comments | « tests/scm_unittest.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698