Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 3117017: Remove deprecated wstring Get(As)String() methods from Value, etc. (Closed)

Created:
10 years, 4 months ago by viettrungluu
Modified:
9 years, 6 months ago
Reviewers:
brettw, Evan Martin
CC:
chromium-reviews, ncarter (slow), Paul Godavari, dhg, idana, ben+cc_chromium.org, Raghu Simha, Erik does not do reviews, brettw-cc_chromium.org, jam, stuartmorgan+watch_chromium.org, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, tim (not reviewing)
Visibility:
Public.

Description

Remove deprecated wstring Get(As)String() methods from Value, etc. BUG=23581 TEST=builds and passes tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56187

Patch Set 1 #

Patch Set 2 : more fixes, deleted deprecated values unit tests #

Patch Set 3 : more fixes, maybe more to come #

Patch Set 4 : oops #

Patch Set 5 : yet more fixes #

Patch Set 6 : argh #

Patch Set 7 : fix nacl build #

Patch Set 8 : fix win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+497 lines, -975 lines) Patch
M base/json/json_reader_unittest.cc View 2 7 chunks +11 lines, -9 lines 0 comments Download
M base/values.h View 4 chunks +0 lines, -13 lines 0 comments Download
M base/values.cc View 4 chunks +0 lines, -43 lines 0 comments Download
M base/values_unittest.cc View 1 9 chunks +0 lines, -434 lines 0 comments Download
M chrome/browser/autocomplete/search_provider.cc View 4 chunks +14 lines, -10 lines 0 comments Download
M chrome/browser/command_line_pref_store_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/debugger/debugger_remote_service.cc View 12 chunks +35 lines, -45 lines 0 comments Download
M chrome/browser/debugger/devtools_remote_service.h View 3 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/debugger/devtools_remote_service.cc View 4 chunks +20 lines, -17 lines 0 comments Download
M chrome/browser/debugger/extension_ports_remote_service.cc View 10 chunks +42 lines, -42 lines 0 comments Download
M chrome/browser/dom_ui/core_options_handler.cc View 5 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/dom_ui/dom_ui.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_bookmarks_module.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/first_run/first_run_gtk.cc View 4 5 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/first_run/first_run_win.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/history/top_sites.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/importer/importer_bridge.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/notifications/notifications_prefs_cache.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/config_dir_policy_provider_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/pref_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 8 chunks +51 lines, -48 lines 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data.cc View 4 chunks +21 lines, -17 lines 0 comments Download
M chrome/browser/sync/sync_setup_flow.cc View 5 chunks +35 lines, -35 lines 0 comments Download
M chrome/browser/sync/sync_setup_wizard_unittest.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/tabs/pinned_tab_codec.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/translate/translate_prefs.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/views/select_file_dialog.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/common/automation_constants.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/common/automation_constants.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/extension_message_bundle.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_message_bundle.cc View 4 chunks +6 lines, -9 lines 0 comments Download
M chrome/common/extensions/extension_message_bundle_unittest.cc View 6 chunks +25 lines, -26 lines 0 comments Download
M chrome/common/json_value_serializer_unittest.cc View 11 chunks +28 lines, -26 lines 0 comments Download
M chrome/common/plugin_group_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/master_preferences.h View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/installer/util/master_preferences.cc View 2 8 chunks +13 lines, -12 lines 0 comments Download
M chrome/installer/util/master_preferences_constants.h View 1 chunk +28 lines, -28 lines 0 comments Download
M chrome/installer/util/master_preferences_constants.cc View 1 chunk +31 lines, -31 lines 0 comments Download
M chrome/installer/util/master_preferences_dummy.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/master_preferences_unittest.cc View 3 chunks +13 lines, -13 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_consts.h View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_consts.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy_backend.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/service/cloud_print/print_system_cups.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/printer_job_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/automation/tab_proxy.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
viettrungluu
10 years, 4 months ago (2010-08-16 04:52:10 UTC) #1
brettw
10 years, 4 months ago (2010-08-16 04:56:51 UTC) #2
LGTM

On Sun, Aug 15, 2010 at 9:52 PM,  <viettrungluu@chromium.org> wrote:
> Reviewers: brettw, Evan Martin,
>
> Description:
> Remove deprecated wstring Get(As)String() methods from Value, etc.
>
> BUG=23581
> TEST=builds and passes tests
>
> Please review this at http://codereview.chromium.org/3117017/show
>
> Affected files:
>  M base/json/json_reader_unittest.cc
>  M base/values.h
>  M base/values.cc
>  M base/values_unittest.cc
>  M chrome/browser/autocomplete/search_provider.cc
>  M chrome/browser/command_line_pref_store_unittest.cc
>  M chrome/browser/debugger/debugger_remote_service.cc
>  M chrome/browser/debugger/devtools_remote_service.h
>  M chrome/browser/debugger/devtools_remote_service.cc
>  M chrome/browser/debugger/extension_ports_remote_service.cc
>  M chrome/browser/dom_ui/core_options_handler.cc
>  M chrome/browser/dom_ui/dom_ui.cc
>  M chrome/browser/extensions/extension_bookmarks_module.cc
>  M chrome/browser/first_run/first_run_gtk.cc
>  M chrome/browser/history/top_sites.cc
>  M chrome/browser/importer/importer_bridge.cc
>  M chrome/browser/notifications/notifications_prefs_cache.cc
>  M chrome/browser/policy/config_dir_policy_provider_unittest.cc
>  M chrome/browser/pref_service.cc
>  M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
>  M chrome/browser/search_engines/template_url_prepopulate_data.cc
>  M chrome/browser/sync/sync_setup_flow.cc
>  M chrome/browser/sync/sync_setup_wizard_unittest.cc
>  M chrome/browser/tabs/pinned_tab_codec.cc
>  M chrome/browser/translate/translate_prefs.cc
>  M chrome/browser/views/select_file_dialog.cc
>  M chrome/common/automation_constants.h
>  M chrome/common/automation_constants.cc
>  M chrome/common/extensions/extension_message_bundle.h
>  M chrome/common/extensions/extension_message_bundle.cc
>  M chrome/common/extensions/extension_message_bundle_unittest.cc
>  M chrome/common/json_value_serializer_unittest.cc
>  M chrome/common/plugin_group_unittest.cc
>  M chrome/installer/util/master_preferences.h
>  M chrome/installer/util/master_preferences.cc
>  M chrome/installer/util/master_preferences_constants.h
>  M chrome/installer/util/master_preferences_constants.cc
>  M chrome/installer/util/master_preferences_unittest.cc
>  M chrome/service/cloud_print/cloud_print_consts.h
>  M chrome/service/cloud_print/cloud_print_consts.cc
>  M chrome/service/cloud_print/cloud_print_proxy_backend.cc
>  M chrome/service/cloud_print/print_system_cups.cc
>  M chrome/service/cloud_print/printer_job_handler.cc
>  M chrome/test/automation/tab_proxy.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698