Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: chrome/installer/util/master_preferences_unittest.cc

Issue 3117017: Remove deprecated wstring Get(As)String() methods from Value, etc. (Closed)
Patch Set: fix win Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Unit tests for master preferences related methods. 5 // Unit tests for master preferences related methods.
6 6
7 #include "base/file_util.h" 7 #include "base/file_util.h"
8 #include "base/path_service.h" 8 #include "base/path_service.h"
9 #include "base/scoped_ptr.h" 9 #include "base/scoped_ptr.h"
10 #include "chrome/common/chrome_paths.h" 10 #include "chrome/common/chrome_paths.h"
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 74
75 EXPECT_TRUE(installer_util::GetDistroBooleanPreference(prefs.get(), 75 EXPECT_TRUE(installer_util::GetDistroBooleanPreference(prefs.get(),
76 installer_util::master_preferences::kDistroImportSearchPref, &value) && 76 installer_util::master_preferences::kDistroImportSearchPref, &value) &&
77 value); 77 value);
78 EXPECT_TRUE(installer_util::GetDistroBooleanPreference(prefs.get(), 78 EXPECT_TRUE(installer_util::GetDistroBooleanPreference(prefs.get(),
79 installer_util::master_preferences::kDistroImportHistoryPref, &value) && 79 installer_util::master_preferences::kDistroImportHistoryPref, &value) &&
80 value); 80 value);
81 EXPECT_TRUE(installer_util::GetDistroBooleanPreference(prefs.get(), 81 EXPECT_TRUE(installer_util::GetDistroBooleanPreference(prefs.get(),
82 installer_util::master_preferences::kDistroImportBookmarksPref, &value) && 82 installer_util::master_preferences::kDistroImportBookmarksPref, &value) &&
83 value); 83 value);
84 std::wstring str_value; 84 std::string str_value;
85 EXPECT_TRUE(installer_util::GetDistroStringPreference(prefs.get(), 85 EXPECT_TRUE(installer_util::GetDistroStringPreference(prefs.get(),
86 installer_util::master_preferences::kDistroImportBookmarksFromFilePref, 86 installer_util::master_preferences::kDistroImportBookmarksFromFilePref,
87 &str_value)); 87 &str_value));
88 EXPECT_STREQ(L"c:\\foo", str_value.c_str()); 88 EXPECT_STREQ("c:\\foo", str_value.c_str());
89 EXPECT_TRUE(installer_util::GetDistroBooleanPreference(prefs.get(), 89 EXPECT_TRUE(installer_util::GetDistroBooleanPreference(prefs.get(),
90 installer_util::master_preferences::kDistroImportHomePagePref, &value) && 90 installer_util::master_preferences::kDistroImportHomePagePref, &value) &&
91 value); 91 value);
92 92
93 EXPECT_TRUE(installer_util::GetDistroBooleanPreference(prefs.get(), 93 EXPECT_TRUE(installer_util::GetDistroBooleanPreference(prefs.get(),
94 installer_util::master_preferences::kCreateAllShortcuts, &value) && 94 installer_util::master_preferences::kCreateAllShortcuts, &value) &&
95 value); 95 value);
96 EXPECT_TRUE(installer_util::GetDistroBooleanPreference(prefs.get(), 96 EXPECT_TRUE(installer_util::GetDistroBooleanPreference(prefs.get(),
97 installer_util::master_preferences::kDoNotLaunchChrome, &value) && 97 installer_util::master_preferences::kDoNotLaunchChrome, &value) &&
98 value); 98 value);
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 installer_util::master_preferences::kDistroShowWelcomePage, &value)); 159 installer_util::master_preferences::kDistroShowWelcomePage, &value));
160 160
161 EXPECT_TRUE(installer_util::GetDistroBooleanPreference(prefs.get(), 161 EXPECT_TRUE(installer_util::GetDistroBooleanPreference(prefs.get(),
162 installer_util::master_preferences::kDistroImportSearchPref, &value) && 162 installer_util::master_preferences::kDistroImportSearchPref, &value) &&
163 value); 163 value);
164 EXPECT_FALSE(installer_util::GetDistroBooleanPreference(prefs.get(), 164 EXPECT_FALSE(installer_util::GetDistroBooleanPreference(prefs.get(),
165 installer_util::master_preferences::kDistroImportHistoryPref, &value)); 165 installer_util::master_preferences::kDistroImportHistoryPref, &value));
166 EXPECT_TRUE(installer_util::GetDistroBooleanPreference(prefs.get(), 166 EXPECT_TRUE(installer_util::GetDistroBooleanPreference(prefs.get(),
167 installer_util::master_preferences::kDistroImportBookmarksPref, &value)); 167 installer_util::master_preferences::kDistroImportBookmarksPref, &value));
168 EXPECT_FALSE(value); 168 EXPECT_FALSE(value);
169 std::wstring str_value; 169 std::string str_value;
170 EXPECT_FALSE(installer_util::GetDistroStringPreference(prefs.get(), 170 EXPECT_FALSE(installer_util::GetDistroStringPreference(prefs.get(),
171 installer_util::master_preferences::kDistroImportBookmarksFromFilePref, 171 installer_util::master_preferences::kDistroImportBookmarksFromFilePref,
172 &str_value)); 172 &str_value));
173 EXPECT_FALSE(installer_util::GetDistroBooleanPreference(prefs.get(), 173 EXPECT_FALSE(installer_util::GetDistroBooleanPreference(prefs.get(),
174 installer_util::master_preferences::kDistroImportHomePagePref, &value)); 174 installer_util::master_preferences::kDistroImportHomePagePref, &value));
175 175
176 EXPECT_TRUE(installer_util::GetDistroBooleanPreference(prefs.get(), 176 EXPECT_TRUE(installer_util::GetDistroBooleanPreference(prefs.get(),
177 installer_util::master_preferences::kCreateAllShortcuts, &value) && 177 installer_util::master_preferences::kCreateAllShortcuts, &value) &&
178 value); 178 value);
179 EXPECT_TRUE(installer_util::GetDistroBooleanPreference(prefs.get(), 179 EXPECT_TRUE(installer_util::GetDistroBooleanPreference(prefs.get(),
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 prefs_path = prefs_path.AppendASCII("extensions") 234 prefs_path = prefs_path.AppendASCII("extensions")
235 .AppendASCII("good").AppendASCII("Preferences"); 235 .AppendASCII("good").AppendASCII("Preferences");
236 236
237 scoped_ptr<DictionaryValue> prefs( 237 scoped_ptr<DictionaryValue> prefs(
238 installer_util::ParseDistributionPreferences(prefs_path)); 238 installer_util::ParseDistributionPreferences(prefs_path));
239 ASSERT_TRUE(prefs.get() != NULL); 239 ASSERT_TRUE(prefs.get() != NULL);
240 DictionaryValue* extensions = NULL; 240 DictionaryValue* extensions = NULL;
241 EXPECT_TRUE(installer_util::HasExtensionsBlock(prefs.get(), &extensions)); 241 EXPECT_TRUE(installer_util::HasExtensionsBlock(prefs.get(), &extensions));
242 int location = 0; 242 int location = 0;
243 EXPECT_TRUE(extensions->GetInteger( 243 EXPECT_TRUE(extensions->GetInteger(
244 L"behllobkkfkfnphdnhnkndlbkcpglgmj.location", &location)); 244 "behllobkkfkfnphdnhnkndlbkcpglgmj.location", &location));
245 int state = 0; 245 int state = 0;
246 EXPECT_TRUE(extensions->GetInteger( 246 EXPECT_TRUE(extensions->GetInteger(
247 L"behllobkkfkfnphdnhnkndlbkcpglgmj.state", &state)); 247 "behllobkkfkfnphdnhnkndlbkcpglgmj.state", &state));
248 std::wstring path; 248 std::string path;
249 EXPECT_TRUE(extensions->GetString( 249 EXPECT_TRUE(extensions->GetString(
250 L"behllobkkfkfnphdnhnkndlbkcpglgmj.path", &path)); 250 "behllobkkfkfnphdnhnkndlbkcpglgmj.path", &path));
251 std::wstring key; 251 std::string key;
252 EXPECT_TRUE(extensions->GetString( 252 EXPECT_TRUE(extensions->GetString(
253 L"behllobkkfkfnphdnhnkndlbkcpglgmj.manifest.key", &key)); 253 "behllobkkfkfnphdnhnkndlbkcpglgmj.manifest.key", &key));
254 std::wstring name; 254 std::string name;
255 EXPECT_TRUE(extensions->GetString( 255 EXPECT_TRUE(extensions->GetString(
256 L"behllobkkfkfnphdnhnkndlbkcpglgmj.manifest.name", &name)); 256 "behllobkkfkfnphdnhnkndlbkcpglgmj.manifest.name", &name));
257 std::wstring version; 257 std::string version;
258 EXPECT_TRUE(extensions->GetString( 258 EXPECT_TRUE(extensions->GetString(
259 L"behllobkkfkfnphdnhnkndlbkcpglgmj.manifest.version", &version)); 259 "behllobkkfkfnphdnhnkndlbkcpglgmj.manifest.version", &version));
260 } 260 }
261 261
262 // Test that we are parsing master preferences correctly. 262 // Test that we are parsing master preferences correctly.
263 TEST_F(MasterPreferencesTest, GetInstallPreferencesTest) { 263 TEST_F(MasterPreferencesTest, GetInstallPreferencesTest) {
264 // Create a temporary prefs file. 264 // Create a temporary prefs file.
265 FilePath prefs_file; 265 FilePath prefs_file;
266 ASSERT_TRUE(file_util::CreateTemporaryFile(&prefs_file)); 266 ASSERT_TRUE(file_util::CreateTemporaryFile(&prefs_file));
267 const char text[] = 267 const char text[] =
268 "{ \n" 268 "{ \n"
269 " \"distribution\": { \n" 269 " \"distribution\": { \n"
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
329 installer_util::master_preferences::kDoNotLaunchChrome, &value) && 329 installer_util::master_preferences::kDoNotLaunchChrome, &value) &&
330 value); 330 value);
331 EXPECT_TRUE(installer_util::GetDistroBooleanPreference(prefs.get(), 331 EXPECT_TRUE(installer_util::GetDistroBooleanPreference(prefs.get(),
332 installer_util::master_preferences::kAltShortcutText, &value) && 332 installer_util::master_preferences::kAltShortcutText, &value) &&
333 value); 333 value);
334 EXPECT_FALSE(installer_util::GetDistroBooleanPreference(prefs.get(), 334 EXPECT_FALSE(installer_util::GetDistroBooleanPreference(prefs.get(),
335 installer_util::master_preferences::kSystemLevel, &value)); 335 installer_util::master_preferences::kSystemLevel, &value));
336 EXPECT_FALSE(installer_util::GetDistroBooleanPreference(prefs.get(), 336 EXPECT_FALSE(installer_util::GetDistroBooleanPreference(prefs.get(),
337 installer_util::master_preferences::kVerboseLogging, &value)); 337 installer_util::master_preferences::kVerboseLogging, &value));
338 } 338 }
OLDNEW
« no previous file with comments | « chrome/installer/util/master_preferences_dummy.cc ('k') | chrome/service/cloud_print/cloud_print_consts.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698