Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 3115011: Update tlslite README.chromium and add a patch for r53724 (Closed)

Created:
10 years, 4 months ago by Ryan Sleevi
Modified:
9 years, 7 months ago
Reviewers:
wtc, zel, Nirnimesh
CC:
chromium-reviews
Visibility:
Public.

Description

Update tlslite README.chromium and add a patch for r53724 BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56977

Patch Set 1 #

Patch Set 2 : Move patches to patches/ subdir #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -5 lines) Patch
M third_party/tlslite/README.chromium View 1 1 chunk +9 lines, -6 lines 0 comments Download
A + third_party/tlslite/patches/close_notify.patch View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/tlslite/patches/python26.patch View 1 chunk +95 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ryan Sleevi
I wasn't sure if it was absolutely necessary to track every change from dist and ...
10 years, 4 months ago (2010-08-14 21:57:39 UTC) #1
zel
LGTM
10 years, 4 months ago (2010-08-15 04:52:03 UTC) #2
wtc
Don't forget to delete src/third_party/tlslite/chromium.patch. (It's actually the close_notify.patch mentioned in README.chromium.)
10 years, 4 months ago (2010-08-18 00:23:39 UTC) #3
Ryan Sleevi
10 years, 4 months ago (2010-08-18 00:44:38 UTC) #4
On 2010/08/18 00:23:39, wtc wrote:
> Don't forget to delete src/third_party/tlslite/chromium.patch.
> (It's actually the close_notify.patch mentioned in README.chromium.)

Right. I may need to follow up with evan on this - git diff -M -C picks up the
rename, but git cl upload didn't notice the delete (so I'm guessing git cl
dcommit won't either). I'll land it once I get that cleared up.

Powered by Google App Engine
This is Rietveld 408576698