Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2881026: Replaced sha, md5 module imports with hashlib (Closed)

Created:
10 years, 5 months ago by zel
Modified:
9 years, 6 months ago
Reviewers:
ericli, Nirnimesh
CC:
chromium-reviews
Visibility:
Public.

Description

Replaced sha, md5 module imports with hashlib. TEST=make sure desktopui_BrowserTest autotest works on ChromeOS BUG=chromium-os:4828 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53724

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -7 lines) Patch
M third_party/tlslite/tlslite/TLSRecordLayer.py View 1 2 3 4 5 1 chunk +13 lines, -2 lines 0 comments Download
M third_party/tlslite/tlslite/mathtls.py View 1 2 3 4 5 1 chunk +12 lines, -2 lines 0 comments Download
M third_party/tlslite/tlslite/messages.py View 1 2 3 4 5 1 chunk +11 lines, -2 lines 0 comments Download
M third_party/tlslite/tlslite/utils/cryptomath.py View 1 2 3 4 5 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
zel
Autotest for browser_tests does not work on ChromeOS without this change. Python complains about these ...
10 years, 5 months ago (2010-07-21 03:17:08 UTC) #1
Nirnimesh
http://codereview.chromium.org/2881026/diff/1/2 File third_party/tlslite/tlslite/TLSRecordLayer.py (right): http://codereview.chromium.org/2881026/diff/1/2#newcode15 third_party/tlslite/tlslite/TLSRecordLayer.py:15: import hashlib Did you mean "from hashlib import md5, ...
10 years, 5 months ago (2010-07-21 08:51:18 UTC) #2
zel
made some other changes to make this happy on all previous python versions as well ...
10 years, 5 months ago (2010-07-24 01:11:28 UTC) #3
Nirnimesh
10 years, 5 months ago (2010-07-24 02:44:15 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698