Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 3115004: Fix fuzzer-found error where left and right were the same register in bitops. (Closed)

Created:
10 years, 4 months ago by Erik Corry
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix fuzzer-found error where left and right were the same register in bitops. Committed: http://code.google.com/p/v8/source/detail?r=5231

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -8 lines) Patch
M src/ia32/codegen-ia32.cc View 1 5 chunks +8 lines, -8 lines 0 comments Download
M src/ia32/virtual-frame-ia32.h View 1 1 chunk +16 lines, -0 lines 0 comments Download
A test/mjsunit/regress/bitops-register-alias.js View 1 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Erik Corry
10 years, 4 months ago (2010-08-10 12:16:16 UTC) #1
Søren Thygesen Gjesse
Drive by comment. http://codereview.chromium.org/3115004/diff/1/4 File test/mjsunit/regress/bitops-register-alias.js (right): http://codereview.chromium.org/3115004/diff/1/4#newcode28 test/mjsunit/regress/bitops-register-alias.js:28: // Whenever we enter a with-scope, ...
10 years, 4 months ago (2010-08-10 12:22:53 UTC) #2
Erik Corry
http://codereview.chromium.org/3115004/diff/1/4 File test/mjsunit/regress/bitops-register-alias.js (right): http://codereview.chromium.org/3115004/diff/1/4#newcode28 test/mjsunit/regress/bitops-register-alias.js:28: // Whenever we enter a with-scope, we copy the ...
10 years, 4 months ago (2010-08-10 12:28:27 UTC) #3
Mads Ager (chromium)
LGTM when test comment has been fixed.
10 years, 4 months ago (2010-08-10 12:28:32 UTC) #4
Mads Ager (chromium)
10 years, 4 months ago (2010-08-10 12:29:08 UTC) #5
LGTM, except for the part about using vi. ;)

Powered by Google App Engine
This is Rietveld 408576698