Issue 3114013: Change rollback interface so kernel/firmware version numbers are

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3114013: Change rollback interface so kernel/firmware version numbers are (Closed)

Created:
10 years, 4 months ago by Randall Spangler

Modified:
9 years, 7 months ago

Reviewers:
Luigi Semenzato, gauravsh

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://gitrw.chromium.org/vboot_reference.git

Visibility:
Public.

Change rollback interface so kernel/firmware version numbers are packed in the calling code rather than in rollback_index.

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -102 lines)			Patch
M	firmware/lib/include/rollback_index.h	View	2 chunks	+4 lines, -8 lines	0 comments	Download
M	firmware/lib/rollback_index.c	View	5 chunks	+19 lines, -35 lines	0 comments	Download
M	firmware/lib/vboot_firmware.c	View	7 chunks	+13 lines, -24 lines	0 comments	Download
M	firmware/lib/vboot_kernel.c	View	8 chunks	+17 lines, -28 lines	0 comments	Download
M	firmware/linktest/main.c	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	firmware/version.c	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Luigi Semenzato

10 years, 4 months ago (2010-08-16 20:35:04 UTC) #3

LGTM

On Mon, Aug 16, 2010 at 11:52 AM,  <gauravsh@chromium.org> wrote:
> lgtm
>
> http://codereview.chromium.org/3114013/show
>